Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2776983003: Expand FrameSelection/SelectionEditor::firstRange() (Closed)

Created:
3 years, 8 months ago by yoichio
Modified:
3 years, 8 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Expand FrameSelection/SelectionEditor::firstRange() Expand firstRange() to simplify code. BUG=693975 TEST=No change in behavior Review-Url: https://codereview.chromium.org/2776983003 Cr-Commit-Position: refs/heads/master@{#459714} Committed: https://chromium.googlesource.com/chromium/src/+/fde595e0f1b0fe737bd7c0c6e3c196da75ccf20d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -27 lines) Patch
M third_party/WebKit/Source/core/editing/DOMSelection.cpp View 1 chunk +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp View 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionEditor.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionEditor.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
yoichio
3 years, 8 months ago (2017-03-27 06:43:06 UTC) #7
yosin_UTC9
lgtm Good catch!
3 years, 8 months ago (2017-03-27 07:16:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2776983003/1
3 years, 8 months ago (2017-03-27 07:19:33 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-03-27 07:24:24 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fde595e0f1b0fe737bd7c0c6e3c1...

Powered by Google App Engine
This is Rietveld 408576698