Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2776943003: Use base::EraseIf in Password Form Manager (Closed)

Created:
3 years, 9 months ago by jdoerrie
Modified:
3 years, 9 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use base::EraseIf in Password Form Manager As a quick follow up to http://crrev.com/2774653006 this change replaces the erase-remove idiom with base::EraseIf in password_form_manager.cc BUG=705433 R=vabr@chromium.org Review-Url: https://codereview.chromium.org/2776943003 Cr-Commit-Position: refs/heads/master@{#459749} Committed: https://chromium.googlesource.com/chromium/src/+/c1e6a51270ce12fc32415422903d2735a8455b56

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -17 lines) Patch
M components/password_manager/core/browser/password_form_manager.cc View 2 chunks +9 lines, -17 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
jdoerrie
Hi Vaclav, please review :)
3 years, 9 months ago (2017-03-27 08:35:01 UTC) #3
vabr (Chromium)
LGTM, switching to EraseIf as well as bundling the checks together makes the code easier ...
3 years, 9 months ago (2017-03-27 08:47:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2776943003/1
3 years, 9 months ago (2017-03-27 10:59:14 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-27 11:05:28 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c1e6a51270ce12fc32415422903d...

Powered by Google App Engine
This is Rietveld 408576698