Revert of Removed SelectionPopupController.invalidateActionMode()

Revert of Removed SelectionPopupController.invalidateActionMode() (patchset #2 id:20001 of https://codereview.chromium.org/2767183002/ )

Reason for revert:
For non-floating menu we should invalidate instead of destroying and creating.

Original issue's description:
> Removed SelectionPopupController.invalidateActionMode()
> 
> I believe invalidateActionMode() is not necessary. The only callsite
> for it is in showActionMode() and it is only called if
> isActionModeValid() is true. The callsites for showActionMode() are:
> 
> 1) SelectionPopupController.restoreSelectionPopupsIfNecessary which
>    only calls showActionMode() if isActionModeValid() is false.
>    Since showActionMode() won't call invalidateActionMode() if
>    isActionModeValid() is false this case can't result in a call.
> 
> 2) ContentViewCore.showSelectActionMode() which in turn is only called
>    in ContentViewCore.onRotationChanged().  In onRotationChanged(),
>    showSelectActionMode() is called right after
>    hidePopupsAndPreserveSelection() which makes isActionModeValid()
>    false. Again this means that showActionMode() wont result result
>    in invalidateActionMode() being called.
> 
> 3) SelectionPopupController.onSelectionEvent() when the event is
>    SELECTION_HANDLES_SHOWN. As far as I know SELECTION_HANDLES_SHOWN
>    should result in a new action mode since it means we have a new
>    selection. I can't think of a reason why we'd want to invalidate
>    instead of destroying the old action mode creating a new one.
> 
> Review-Url: https://codereview.chromium.org/2767183002
> Cr-Commit-Position: refs/heads/master@{#458997}
> Committed: https://chromium.googlesource.com/chromium/src/+/31843a5be08800e6bdf2a1f7c07eef342ad1abc6

TBR=boliu@chromium.org,jinsukkim@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.

Review-Url: https://codereview.chromium.org/2776883002
Cr-Commit-Position: refs/heads/master@{#459839}
Committed: https://chromium.googlesource.com/chromium/src/+/4755d3b46ddba3c81c6727275865d1968f528dc4

[amaralp, 2017-03-25 02:32:18]

The CQ bit was checked by amaralp@chromium.org

[amaralp, 2017-03-25 02:32:18]

Created Revert of Removed SelectionPopupController.invalidateActionMode()

[commit-bot: I haz the power, 2017-03-25 02:32:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-25 02:32:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-25 02:32:37]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[boliu, 2017-03-25 21:17:00]

lgtm

[Jinsuk Kim, 2017-03-27 03:05:03]

lgtm

[amaralp, 2017-03-27 17:50:28]

The CQ bit was checked by amaralp@chromium.org

[commit-bot: I haz the power, 2017-03-27 17:51:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 18:37:56]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490637028917490, "parent_rev":
"3a98b737d9b2f9a72f77ca38403c7a22988b5ed1", "commit_rev":
"4755d3b46ddba3c81c6727275865d1968f528dc4"}

[commit-bot: I haz the power, 2017-03-27 18:38:40]

Description was changed from

==========
Revert of Removed SelectionPopupController.invalidateActionMode() (patchset #2
id:20001 of https://codereview.chromium.org/2767183002/ )

Reason for revert:
For non-floating menu we should invalidate instead of destroying and creating.

Original issue's description:
> Removed SelectionPopupController.invalidateActionMode()
> 
> I believe invalidateActionMode() is not necessary. The only callsite
> for it is in showActionMode() and it is only called if
> isActionModeValid() is true. The callsites for showActionMode() are:
> 
> 1) SelectionPopupController.restoreSelectionPopupsIfNecessary which
>    only calls showActionMode() if isActionModeValid() is false.
>    Since showActionMode() won't call invalidateActionMode() if
>    isActionModeValid() is false this case can't result in a call.
> 
> 2) ContentViewCore.showSelectActionMode() which in turn is only called
>    in ContentViewCore.onRotationChanged().  In onRotationChanged(),
>    showSelectActionMode() is called right after
>    hidePopupsAndPreserveSelection() which makes isActionModeValid()
>    false. Again this means that showActionMode() wont result result
>    in invalidateActionMode() being called.
> 
> 3) SelectionPopupController.onSelectionEvent() when the event is
>    SELECTION_HANDLES_SHOWN. As far as I know SELECTION_HANDLES_SHOWN
>    should result in a new action mode since it means we have a new
>    selection. I can't think of a reason why we'd want to invalidate
>    instead of destroying the old action mode creating a new one.
> 
> Review-Url: https://codereview.chromium.org/2767183002
> Cr-Commit-Position: refs/heads/master@{#458997}
> Committed:
https://chromium.googlesource.com/chromium/src/+/31843a5be08800e6bdf2a1f7c07e...

TBR=boliu@chromium.org,jinsukkim@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
==========

to

==========
Revert of Removed SelectionPopupController.invalidateActionMode() (patchset #2
id:20001 of https://codereview.chromium.org/2767183002/ )

Reason for revert:
For non-floating menu we should invalidate instead of destroying and creating.

Original issue's description:
> Removed SelectionPopupController.invalidateActionMode()
> 
> I believe invalidateActionMode() is not necessary. The only callsite
> for it is in showActionMode() and it is only called if
> isActionModeValid() is true. The callsites for showActionMode() are:
> 
> 1) SelectionPopupController.restoreSelectionPopupsIfNecessary which
>    only calls showActionMode() if isActionModeValid() is false.
>    Since showActionMode() won't call invalidateActionMode() if
>    isActionModeValid() is false this case can't result in a call.
> 
> 2) ContentViewCore.showSelectActionMode() which in turn is only called
>    in ContentViewCore.onRotationChanged().  In onRotationChanged(),
>    showSelectActionMode() is called right after
>    hidePopupsAndPreserveSelection() which makes isActionModeValid()
>    false. Again this means that showActionMode() wont result result
>    in invalidateActionMode() being called.
> 
> 3) SelectionPopupController.onSelectionEvent() when the event is
>    SELECTION_HANDLES_SHOWN. As far as I know SELECTION_HANDLES_SHOWN
>    should result in a new action mode since it means we have a new
>    selection. I can't think of a reason why we'd want to invalidate
>    instead of destroying the old action mode creating a new one.
> 
> Review-Url: https://codereview.chromium.org/2767183002
> Cr-Commit-Position: refs/heads/master@{#458997}
> Committed:
https://chromium.googlesource.com/chromium/src/+/31843a5be08800e6bdf2a1f7c07e...

TBR=boliu@chromium.org,jinsukkim@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.

Review-Url: https://codereview.chromium.org/2776883002
Cr-Commit-Position: refs/heads/master@{#459839}
Committed:
https://chromium.googlesource.com/chromium/src/+/4755d3b46ddba3c81c6727275865...
==========

[commit-bot: I haz the power, 2017-03-27 18:38:41]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4755d3b46ddba3c81c6727275865...