Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2776873002: Modify tests to ensure URLRequestJob::DoneReading is always called. (Closed)

Created:
3 years, 9 months ago by lazyboy
Modified:
3 years, 8 months ago
Reviewers:
mmenke
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, cbentzel+watch_chromium.org, net-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Modify tests to ensure URLRequestJob::DoneReading is always called, even for zero byte files. URLRequestExtensionJob depends on this behavior, so add a zero-byte test to url_request_file_job_unittest. Also update other relevant tests in that file to check for DoneReading. This is merely a test addition/modification for crbug.com/703892 BUG=703892 Test=None, internal change only. Review-Url: https://codereview.chromium.org/2776873002 Cr-Commit-Position: refs/heads/master@{#460507} Committed: https://chromium.googlesource.com/chromium/src/+/306eec3b648d47328aba78b0c80bf1d59f72f42e

Patch Set 1 #

Patch Set 2 : Ready for review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -8 lines) Patch
M net/url_request/url_request_file_job_unittest.cc View 1 16 chunks +37 lines, -8 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
lazyboy
3 years, 8 months ago (2017-03-29 17:54:55 UTC) #7
mmenke
LGTM!
3 years, 8 months ago (2017-03-29 18:40:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2776873002/40001
3 years, 8 months ago (2017-03-29 19:59:37 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 20:07:09 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/306eec3b648d47328aba78b0c80b...

Powered by Google App Engine
This is Rietveld 408576698