Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2776763002:
MD Settings: Fix scroll when navigating from subpage to About and back. (Closed)
|
Created:
3 years, 9 months ago by tommycli Modified:
3 years, 9 months ago Reviewers:
dpapad CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionMD Settings: Fix scroll when navigating from subpage to About and back.
Scrolling is still pretty fragile, but this patch fixes a regression
introduced in the below bug.
BUG=703041
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2776763002
Cr-Commit-Position: refs/heads/master@{#459587}
Committed: https://chromium.googlesource.com/chromium/src/+/56ebfeb15a6e2e9284ae2156202b2e8eaef72e03
Patch Set 1 #
Depends on Patchset: Messages
Total messages: 18 (10 generated)
Description was changed from ========== MD Settings: Fix scroll when navigating from subpage to About and back. Scrolling is still pretty fragile, but this patch fixes a regression introduced in the below bug. BUG=703401 ========== to ========== MD Settings: Fix scroll when navigating from subpage to About and back. Scrolling is still pretty fragile, but this patch fixes a regression introduced in the below bug. BUG=703401 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by tommycli@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
tommycli@chromium.org changed reviewers: + dpapad@chromium.org
dpapad: PTAL thank you for your consult, your advice to focus on the bisect really helped me narrow it down (seems obvious in retrospect :D)
On 2017/03/24 at 21:50:11, tommycli wrote: > dpapad: PTAL thank you for your consult, your advice to focus on the bisect really helped me narrow it down (seems obvious in retrospect :D) Glad I could help. LGTM Following up from our in-person conversation, I think the more Route.ABOUT and Route.BASIC references exist in main_page_behavior.js the more it becomes apparent that this file has ended up holding logic that belongs to the two subclasses (about_page and basic_page), and basically at this point the subclasses have started creeping up in the super class. Definitely feels that we have some debt in that part of the code. Also I don't know if it is feasible to write solid automated tests for our scrolling code, which is why I am not blocking this CL on such tests.
On 2017/03/24 22:05:50, dpapad wrote: > On 2017/03/24 at 21:50:11, tommycli wrote: > > dpapad: PTAL thank you for your consult, your advice to focus on the bisect > really helped me narrow it down (seems obvious in retrospect :D) > > Glad I could help. LGTM > > Following up from our in-person conversation, I think the more Route.ABOUT and > Route.BASIC references exist in main_page_behavior.js the more it becomes > apparent that this file has ended up holding logic that belongs to the two > subclasses (about_page and basic_page), and basically at this point the > subclasses have started creeping up in the super class. Definitely feels that we > have some debt in that part of the code. Also I don't know if it is feasible to > write solid automated tests for our scrolling code, which is why I am not > blocking this CL on such tests. Thanks! Yeah -- definitely room for some refactor here.
The CQ bit was unchecked by tommycli@chromium.org
The CQ bit was checked by tommycli@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1490393242392650, "parent_rev":
"084c73aa124fd5e60cbc2e686840386c5483daac", "commit_rev":
"078741e688f221a75a5035455bfe7bb32d6c7f96"}
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1490393242392650, "parent_rev":
"0f0258789741b3e0cc7e0a0697cd87010e23e4ce", "commit_rev":
"56ebfeb15a6e2e9284ae2156202b2e8eaef72e03"}
Message was sent while issue was closed.
Description was changed from ========== MD Settings: Fix scroll when navigating from subpage to About and back. Scrolling is still pretty fragile, but this patch fixes a regression introduced in the below bug. BUG=703401 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: Fix scroll when navigating from subpage to About and back. Scrolling is still pretty fragile, but this patch fixes a regression introduced in the below bug. BUG=703401 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2776763002 Cr-Commit-Position: refs/heads/master@{#459587} Committed: https://chromium.googlesource.com/chromium/src/+/56ebfeb15a6e2e9284ae2156202b... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/56ebfeb15a6e2e9284ae2156202b...
Message was sent while issue was closed.
On 2017/03/24 at 22:59:17, commit-bot wrote: > Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/56ebfeb15a6e2e9284ae2156202b... nbd but it looks like the BUG= on this is incorrect
Message was sent while issue was closed.
On 2017/03/24 at 23:13:15, jeffcarp wrote: > On 2017/03/24 at 22:59:17, commit-bot wrote: > > Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/56ebfeb15a6e2e9284ae2156202b... > > nbd but it looks like the BUG= on this is incorrect Correct bug is crbug.com/703041.
Message was sent while issue was closed.
Description was changed from ========== MD Settings: Fix scroll when navigating from subpage to About and back. Scrolling is still pretty fragile, but this patch fixes a regression introduced in the below bug. BUG=703401 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2776763002 Cr-Commit-Position: refs/heads/master@{#459587} Committed: https://chromium.googlesource.com/chromium/src/+/56ebfeb15a6e2e9284ae2156202b... ========== to ========== MD Settings: Fix scroll when navigating from subpage to About and back. Scrolling is still pretty fragile, but this patch fixes a regression introduced in the below bug. BUG=703041 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2776763002 Cr-Commit-Position: refs/heads/master@{#459587} Committed: https://chromium.googlesource.com/chromium/src/+/56ebfeb15a6e2e9284ae2156202b... ==========
Message was sent while issue was closed.
On 2017/03/24 23:19:11, dpapad wrote: > On 2017/03/24 at 23:13:15, jeffcarp wrote: > > On 2017/03/24 at 22:59:17, commit-bot wrote: > > > Committed patchset #1 (id:1) as > https://chromium.googlesource.com/chromium/src/+/56ebfeb15a6e2e9284ae2156202b... > > > > nbd but it looks like the BUG= on this is incorrect > > Correct bug is crbug.com/703041. Oops. How hard would it be to make a presubmit that printed out the bug prominently before uploading? Worth it? |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
