[selectors-4] Import W3C Test Suite

[selectors-4] Import W3C Test Suite

This patch imports "selectors-4" test suite from W3C csswg-test repo:
https://github.com/w3c/csswg-test/tree/master/selectors-4/

Only 2 tests are passing right now. Other fail because of
the psuedo-classes haven't been implemented yet:
:dir (crbug.com/576815) and :focus-within (crbug.com/617371).

BUG=704902
Review-Url: https://codereview.chromium.org/2776693002
Cr-Commit-Position: refs/heads/master@{#459401}
Committed: https://chromium.googlesource.com/chromium/src/+/567655f3f72b9ac9754c2fccfcacca4953d4c656

[Manuel Rego, 2017-03-24 11:26:25]

rego@igalia.com changed reviewers:
+ jfernandez@igalia.com, kojii@chromium.org, qyearsley@chromium.org

[Manuel Rego, 2017-03-24 11:26:26]

The test suite has a bunch of tests for :focus-within,
which I'm planning to implement in the coming weeks.

[jfernandez, 2017-03-24 12:13:32]

lgtm but I have some doubts about the description. First of all, you have used
the same bug number twice. 

In addition, I dont't understand why this CL fixes that bug, which is about to
implement CSS4 pseudo-class :dir(). This CL is only about importing the Test
Suite.

[Manuel Rego, 2017-03-24 12:21:18]

Description was changed from

==========
[selectors-4] Import W3C Test Suite

This patch imports "selectors-4" test suite from W3C csswg-test repo:
https://github.com/w3c/csswg-test/tree/master/selectors-4/

Only 2 tests are passing right now. Other fail because of
the psuedo-classes haven't been implemented yet
(:dir and :focus-within).

BUG=576815,576815
==========

to

==========
[selectors-4] Import W3C Test Suite

This patch imports "selectors-4" test suite from W3C csswg-test repo:
https://github.com/w3c/csswg-test/tree/master/selectors-4/

Only 2 tests are passing right now. Other fail because of
the psuedo-classes haven't been implemented yet
(:dir and :focus-within).

BUG=576815,617371
==========

[Manuel Rego, 2017-03-24 12:23:41]

Thanks for the quick review!

On 2017/03/24 12:13:32, jfernandez wrote:
> lgtm but I have some doubts about the description. First of all, you have used
> the same bug number twice. 

Oops, sorry I meant to use 2 bugs: 576815 and 617371.

> In addition, I dont't understand why this CL fixes that bug, which is about to
> implement CSS4 pseudo-class :dir(). This CL is only about importing the Test
> Suite.

This doesn't fix those bugs, but it's somehow related as it's adding tests for
them.

Are you fine with this or do you prefer any other option?
A) Remove BUG= line in this CL.
B) Report a specific bug for importing this test suite and only link that one in
the CL.
C) Report the bug for importing the test suite and link the 3 bugs on this CL.
:-)

[jfernandez, 2017-03-24 12:40:22]

On 2017/03/24 12:23:41, Manuel Rego wrote:
> Thanks for the quick review!
> 
> On 2017/03/24 12:13:32, jfernandez wrote:
> > lgtm but I have some doubts about the description. First of all, you have
used
> > the same bug number twice. 
> 
> Oops, sorry I meant to use 2 bugs: 576815 and 617371.
> 
> > In addition, I dont't understand why this CL fixes that bug, which is about
to
> > implement CSS4 pseudo-class :dir(). This CL is only about importing the Test
> > Suite.
> 
> This doesn't fix those bugs, but it's somehow related as it's adding tests for
> them.
> 
> Are you fine with this or do you prefer any other option?
> A) Remove BUG= line in this CL.
> B) Report a specific bug for importing this test suite and only link that one
in
> the CL.
> C) Report the bug for importing the test suite and link the 3 bugs on this CL.
> :-)

Either A or B are good options, in my opinion. But I don't oppose to have these
2 bugs in the description of the CL; it was just I was surprised. I would 
discard C in any case.

[Manuel Rego, 2017-03-24 12:48:03]

Description was changed from

==========
[selectors-4] Import W3C Test Suite

This patch imports "selectors-4" test suite from W3C csswg-test repo:
https://github.com/w3c/csswg-test/tree/master/selectors-4/

Only 2 tests are passing right now. Other fail because of
the psuedo-classes haven't been implemented yet
(:dir and :focus-within).

BUG=576815,617371
==========

to

==========
[selectors-4] Import W3C Test Suite

This patch imports "selectors-4" test suite from W3C csswg-test repo:
https://github.com/w3c/csswg-test/tree/master/selectors-4/

Only 2 tests are passing right now. Other fail because of
the psuedo-classes haven't been implemented yet:
:dir (crbug.com/576815) and :focus-within (crbug.com/617371).

BUG=704902
==========

[Manuel Rego, 2017-03-24 12:48:43]

On 2017/03/24 12:40:22, jfernandez wrote:
> On 2017/03/24 12:23:41, Manuel Rego wrote:
> > Are you fine with this or do you prefer any other option?
> > A) Remove BUG= line in this CL.
> > B) Report a specific bug for importing this test suite and only link that
one
> in
> > the CL.
> > C) Report the bug for importing the test suite and link the 3 bugs on this
CL.
> > :-)
> 
> Either A or B are good options, in my opinion. But I don't oppose to have
these
> 2 bugs in the description of the CL; it was just I was surprised. I would 
> discard C in any case.

Ok, I've gone with B) at the end. Thanks!

[Manuel Rego, 2017-03-24 12:48:48]

The CQ bit was checked by rego@igalia.com

[commit-bot: I haz the power, 2017-03-24 12:49:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 13:23:12]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490359728879890, "parent_rev":
"73f6c4b838a092a6e7e7eb29a288cc9b5930aeac", "commit_rev":
"567655f3f72b9ac9754c2fccfcacca4953d4c656"}

[commit-bot: I haz the power, 2017-03-24 13:24:02]

Description was changed from

==========
[selectors-4] Import W3C Test Suite

This patch imports "selectors-4" test suite from W3C csswg-test repo:
https://github.com/w3c/csswg-test/tree/master/selectors-4/

Only 2 tests are passing right now. Other fail because of
the psuedo-classes haven't been implemented yet:
:dir (crbug.com/576815) and :focus-within (crbug.com/617371).

BUG=704902
==========

to

==========
[selectors-4] Import W3C Test Suite

This patch imports "selectors-4" test suite from W3C csswg-test repo:
https://github.com/w3c/csswg-test/tree/master/selectors-4/

Only 2 tests are passing right now. Other fail because of
the psuedo-classes haven't been implemented yet:
:dir (crbug.com/576815) and :focus-within (crbug.com/617371).

BUG=704902

Review-Url: https://codereview.chromium.org/2776693002
Cr-Commit-Position: refs/heads/master@{#459401}
Committed:
https://chromium.googlesource.com/chromium/src/+/567655f3f72b9ac9754c2fccfcac...
==========

[commit-bot: I haz the power, 2017-03-24 13:24:03]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/567655f3f72b9ac9754c2fccfcac...

[qyearsley, 2017-03-24 16:04:13]

lgtm