Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 2776693002: [selectors-4] Import W3C Test Suite (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months ago by Manuel Rego
Modified:
2 months ago
Reviewers:
jfernandez, kojii, qyearsley
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[selectors-4] Import W3C Test Suite This patch imports "selectors-4" test suite from W3C csswg-test repo: https://github.com/w3c/csswg-test/tree/master/selectors-4/ Only 2 tests are passing right now. Other fail because of the psuedo-classes haven't been implemented yet: :dir (crbug.com/576815) and :focus-within (crbug.com/617371). BUG=704902 Review-Url: https://codereview.chromium.org/2776693002 Cr-Commit-Position: refs/heads/master@{#459401} Committed: https://chromium.googlesource.com/chromium/src/+/567655f3f72b9ac9754c2fccfcacca4953d4c656

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+885 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +14 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/W3CImportExpectations View 2 chunks +3 lines, -2 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/focus-within-001.html View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/focus-within-001-expected.html View 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/focus-within-002.html View 1 chunk +40 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/focus-within-002-expected.html View 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/focus-within-003.html View 1 chunk +46 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/focus-within-003-expected.html View 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/focus-within-004.html View 1 chunk +51 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/focus-within-004-expected.html View 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/focus-within-005.html View 1 chunk +52 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/focus-within-005-expected.html View 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/focus-within-006.html View 1 chunk +54 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/focus-within-006-expected.html View 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/focus-within-shadow-001.html View 1 chunk +40 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/focus-within-shadow-001-expected.html View 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/focus-within-shadow-002.html View 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/focus-within-shadow-002-expected.html View 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/focus-within-shadow-003.html View 1 chunk +43 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/focus-within-shadow-003-expected.html View 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/focus-within-shadow-004.html View 1 chunk +49 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/focus-within-shadow-004-expected.html View 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/focus-within-shadow-005.html View 1 chunk +60 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/focus-within-shadow-005-expected.html View 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/of-type-selectors.xhtml View 1 chunk +32 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/of-type-selectors-expected.xhtml View 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/selector-required.html View 1 chunk +26 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/selector-required-expected.html View 1 chunk +22 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/selectors-dir-selector-ltr-001.html View 1 chunk +26 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/selectors-dir-selector-ltr-001-expected.xht View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/selectors-dir-selector-rtl-001.html View 1 chunk +26 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/selectors-4/selectors-dir-selector-rtl-001-expected.xht View 1 chunk +19 lines, -0 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 14 (6 generated)
Manuel Rego
The test suite has a bunch of tests for :focus-within, which I'm planning to implement ...
2 months ago (2017-03-24 11:26:26 UTC) #2
jfernandez
lgtm but I have some doubts about the description. First of all, you have used ...
2 months ago (2017-03-24 12:13:32 UTC) #3
Manuel Rego
Thanks for the quick review! On 2017/03/24 12:13:32, jfernandez wrote: > lgtm but I have ...
2 months ago (2017-03-24 12:23:41 UTC) #5
jfernandez
On 2017/03/24 12:23:41, Manuel Rego wrote: > Thanks for the quick review! > > On ...
2 months ago (2017-03-24 12:40:22 UTC) #6
Manuel Rego
On 2017/03/24 12:40:22, jfernandez wrote: > On 2017/03/24 12:23:41, Manuel Rego wrote: > > Are ...
2 months ago (2017-03-24 12:48:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2776693002/1
2 months ago (2017-03-24 12:49:04 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/567655f3f72b9ac9754c2fccfcacca4953d4c656
2 months ago (2017-03-24 13:24:03 UTC) #13
qyearsley
2 months ago (2017-03-24 16:04:13 UTC) #14
Message was sent while issue was closed.
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 650457f06