Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2776673002: Add missing passwords files to BUILD.gn (Closed)

Created:
3 years, 9 months ago by vabr (Chromium)
Modified:
3 years, 9 months ago
Reviewers:
vasilii
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing passwords files to BUILD.gn Two files were identified in https://docs.google.com/spreadsheets/d/15az3FMl-jAS0mx4E9XVSBVHVpmEzo-9EAGY0ywe7bZs/edit#gid=0: components/password_manager/core/browser/login_database_ios_unittest.cc chrome/browser/ui/cocoa/passwords/password_prompt_bridge_interface.h This CL adds them to the appropriate build files. R=vasilii@chromium.org BUG=None Review-Url: https://codereview.chromium.org/2776673002 Cr-Commit-Position: refs/heads/master@{#459384} Committed: https://chromium.googlesource.com/chromium/src/+/b874c08258d7ffb293ecf1f779cdf2c61d03e23f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/ui/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/password_manager/core/browser/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
vabr (Chromium)
Hi Vasilii, PTAL. If it looks good, please feel free to send this to the ...
3 years, 9 months ago (2017-03-24 08:53:45 UTC) #3
vasilii
lgtm
3 years, 9 months ago (2017-03-24 09:00:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2776673002/1
3 years, 9 months ago (2017-03-24 09:00:36 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/393819)
3 years, 9 months ago (2017-03-24 09:15:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2776673002/1
3 years, 9 months ago (2017-03-24 09:21:51 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/393834)
3 years, 9 months ago (2017-03-24 09:36:40 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2776673002/1
3 years, 9 months ago (2017-03-24 10:01:12 UTC) #15
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 10:56:29 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b874c08258d7ffb293ecf1f779cd...

Powered by Google App Engine
This is Rietveld 408576698