Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2776643002: Walk the container chain to correctly find nested inline sticky ancestors. (Closed)

Created:
3 years, 9 months ago by flackr
Modified:
3 years, 9 months ago
Reviewers:
smcgruer, chrishtr
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Walk the container chain to correctly find nested inline sticky ancestors. BUG=704814 Review-Url: https://codereview.chromium.org/2776643002 Cr-Commit-Position: refs/heads/master@{#459842} Committed: https://chromium.googlesource.com/chromium/src/+/a1f2ac48e3dc57547c562f759c6adcc1293177ff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -7 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObjectTest.cpp View 3 chunks +21 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
flackr
PTAL, thanks
3 years, 9 months ago (2017-03-24 04:24:45 UTC) #2
smcgruer
lgtm
3 years, 9 months ago (2017-03-24 13:38:15 UTC) #3
flackr
Chris, can you take a look? This fixes a bug that the nested inline sticky ...
3 years, 9 months ago (2017-03-24 13:57:08 UTC) #5
chrishtr
lgtm
3 years, 9 months ago (2017-03-27 16:41:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2776643002/1
3 years, 9 months ago (2017-03-27 17:11:09 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-27 18:53:11 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a1f2ac48e3dc57547c562f759c6a...

Powered by Google App Engine
This is Rietveld 408576698