Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(910)

Unified Diff: chrome/BUILD.gn

Issue 2776613002: media: Move Widevine signature of Framework into a bundle (Closed)
Patch Set: media: Move Framework signature into a bundle Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/common/media/cdm_host_file_path.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/BUILD.gn
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn
index c14a75d3e16051acb4eec704eabc23a83d9baf7f..ff6bbe9bdea3b5ed61c057b20275b9e8fad93cca 100644
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -661,8 +661,8 @@ if (is_win) {
# Only official builds that include Widevine need the widevine
# signature file.
if (is_chrome_branded && enable_pepper_cdms) {
- sources += [ "$root_out_dir/$chrome_framework_name.sig" ]
- public_deps += [ ":sign_chrome_framework_for_widevine" ]
+ sources += [ "$root_out_dir/Widevine Resources.bundle" ]
Nico 2017/03/30 01:19:07 Does having a directory in sources work? I'd expec
Robert Sesek 2017/03/30 03:33:32 Yes, this works because of the deps as well. See l
+ public_deps += [ ":widevine_resources_bundle" ]
}
}
@@ -936,6 +936,50 @@ if (is_win) {
":chrome_framework",
]
}
+
+ mac_info_plist("widevine_resources_plist") {
+ info_plist = "//third_party/widevine/cdm/widevine_resources.plist"
+ extra_substitutions = [
+ "CHROMIUM_BUNDLE_ID=$chrome_mac_bundle_id",
+ "BUNDLE_ID=widevine_resources",
+ ]
+ executable_name = "Widevine Resources"
+ }
+
+ bundle_data("widevine_resources_plist_bundle_data") {
+ sources = get_target_outputs(":widevine_resources_plist")
+ outputs = [
+ "{{bundle_root_dir}}/Info.plist",
+ ]
+ public_deps = [
+ ":widevine_resources_plist",
+ ]
+ }
+
+ bundle_data("framework_widevine_signature") {
+ sources = [
+ "$root_out_dir/$chrome_framework_name.sig",
+ ]
+
+ outputs = [
+ "{{bundle_resources_dir}}/{{source_file_part}}",
+ ]
+
+ public_deps = [
+ ":sign_chrome_framework_for_widevine",
+ ]
+ }
+
+ create_bundle("widevine_resources_bundle") {
+ output_name = "Widevine Resources.bundle"
+ bundle_root_dir = "$root_build_dir/$output_name/Contents"
+ bundle_resources_dir = bundle_root_dir + "/Resources"
+
+ deps = [
+ ":framework_widevine_signature",
+ ":widevine_resources_plist_bundle_data",
+ ]
+ }
}
group("widevine_cdm_library") {
« no previous file with comments | « no previous file | chrome/common/media/cdm_host_file_path.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698