media: Move Widevine signature of Framework into a bundle

chrome/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/buildflag_header.gni")
 import("//build/config/chrome_build.gni")
 import("//build/config/compiler/compiler.gni")
 import("//build/config/compiler/pgo/pgo.gni")
 import("//build/config/features.gni")
 import("//build/config/locales.gni")
@@ skipping 643 matching lines @@
       ":keystone_registration_framework",
 
       # verify_chrome_framework_order depends on :chrome_framework and, for
       # non-component builds, will ensure the export symbol table is correct.
       ":verify_chrome_framework_order",
     ]
 
     # Only official builds that include Widevine need the widevine
     # signature file.
     if (is_chrome_branded && enable_pepper_cdms) {
-      sources += [ "$root_out_dir/$chrome_framework_name.sig" ]
-      public_deps += [ ":sign_chrome_framework_for_widevine" ]
+      sources += [ "$root_out_dir/Widevine Resources.bundle" ]

[Nico, 2017/03/30 01:19:07]

Does having a directory in sources work? I'd expect that this makes something
depend on the directory's timestamp, and if files in subdirectories of that
directory change, the top-level timestamp won't be updated and incremental
builds won't work correctly. Is there any way to list all the input files here?

[Robert Sesek, 2017/03/30 03:33:32]

Yes, this works because of the deps as well. See lines 638 above.

+      public_deps += [ ":widevine_resources_bundle" ]
     }
   }
 
   action("clean_up_old_versions") {
     script = "//chrome/tools/build/mac/clean_up_old_versions.py"
     outputs = [
       "$root_gen_dir/run_$target_name.stamp",
     ]
     args = [
              rebase_path("$root_out_dir/$chrome_product_full_name.app",
@@ skipping 253 matching lines @@
       if (defined(chrome_framework_version)) {
         file += "Versions/$chrome_framework_version/"
       }
       file += "$chrome_framework_name"
       flags = 1
       signature_file = "$root_out_dir/$chrome_framework_name.sig"
       deps = [
         ":chrome_framework",
       ]
     }
+
+    mac_info_plist("widevine_resources_plist") {
+      info_plist = "//third_party/widevine/cdm/widevine_resources.plist"
+      extra_substitutions = [
+        "CHROMIUM_BUNDLE_ID=$chrome_mac_bundle_id",
+        "BUNDLE_ID=widevine_resources",
+      ]
+      executable_name = "Widevine Resources"
+    }
+
+    bundle_data("widevine_resources_plist_bundle_data") {
+      sources = get_target_outputs(":widevine_resources_plist")
+      outputs = [
+        "{{bundle_root_dir}}/Info.plist",
+      ]
+      public_deps = [
+        ":widevine_resources_plist",
+      ]
+    }
+
+    bundle_data("framework_widevine_signature") {
+      sources = [
+        "$root_out_dir/$chrome_framework_name.sig",
+      ]
+
+      outputs = [
+        "{{bundle_resources_dir}}/{{source_file_part}}",
+      ]
+
+      public_deps = [
+        ":sign_chrome_framework_for_widevine",
+      ]
+    }
+
+    create_bundle("widevine_resources_bundle") {
+      output_name = "Widevine Resources.bundle"
+      bundle_root_dir = "$root_build_dir/$output_name/Contents"
+      bundle_resources_dir = bundle_root_dir + "/Resources"
+
+      deps = [
+        ":framework_widevine_signature",
+        ":widevine_resources_plist_bundle_data",
+      ]
+    }
   }
 
   group("widevine_cdm_library") {
     if (_should_bundle_widevine) {
       deps = [
         ":widevine_cdm_library_binaries",
         ":widevine_cdm_library_manifest",
       ]
     }
   }
@@ skipping 733 matching lines @@
       "//chrome/app/theme/$branding_path_component/product_logo_48.png",
       "//chrome/tools/build/linux/chrome-wrapper",
       "//third_party/xdg-utils/scripts/xdg-mime",
       "//third_party/xdg-utils/scripts/xdg-settings",
     ]
     outputs = [
       "$root_out_dir/{{source_file_part}}",
     ]
   }
 }