Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2776583003: Remove setMayNeedPaintInvalidation call from setNeedsOverflowRecalcAfterStyleChange() (Closed)

Created:
3 years, 9 months ago by Xianzhu
Modified:
3 years, 9 months ago
Reviewers:
pdr.
CC:
chromium-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, blink-reviews-layout_chromium.org, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove setMayNeedPaintInvalidation call from setNeedsOverflowRecalcAfterStyleChange() This is a partial revert of https://codereview.chromium.org/2751523011 which caused extra painting cost in some cases. See the bug for data and analysis. Remove the call to fix the regression. Will continue to investigate the case to see if the extra painting cost is legitimate and, if yes, any optimizations to avoid the cost. BUG=704182 Review-Url: https://codereview.chromium.org/2776583003 Cr-Commit-Position: refs/heads/master@{#459556} Committed: https://chromium.googlesource.com/chromium/src/+/d3fc0f37f5b506fbc57edfdeebe02cbeac5b3002

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
Xianzhu
3 years, 9 months ago (2017-03-24 19:58:03 UTC) #3
pdr.
On 2017/03/24 at 19:58:03, wangxianzhu wrote: > LGTM
3 years, 9 months ago (2017-03-24 20:00:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2776583003/1
3 years, 9 months ago (2017-03-24 20:22:38 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 21:22:31 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d3fc0f37f5b506fbc57edfdeebe0...

Powered by Google App Engine
This is Rietveld 408576698