Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 2776513002: Enable PasswordManagerBrowserTestBase.SameOriginIframeAutoFillTest to get more data (Closed)

Created:
3 years, 9 months ago by vasilii
Modified:
3 years, 9 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable PasswordManagerBrowserTestBase.SameOriginIframeAutoFillTest to get more data Currently we know that password_field.value was not expected. The CL changes CheckElementValue() so that it outputs more data for all the password tests. Flakiness in the test may even signify a real bug. BUG=683209 Review-Url: https://codereview.chromium.org/2776513002 Cr-Commit-Position: refs/heads/master@{#459254} Committed: https://chromium.googlesource.com/chromium/src/+/331224fb38ef3a2ef7bcc5eadb7592a0bebd0d02

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -15 lines) Patch
M chrome/browser/password_manager/password_manager_browsertest.cc View 1 chunk +1 line, -7 lines 0 comments Download
M chrome/browser/password_manager/password_manager_test_base.cc View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
vasilii
Hi Vaclav, please review.
3 years, 9 months ago (2017-03-23 18:52:35 UTC) #4
vabr (Chromium)
LGTM, this step for investigation seems reasonable. Cheers, Vaclav
3 years, 9 months ago (2017-03-23 19:34:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2776513002/1
3 years, 9 months ago (2017-03-23 22:15:21 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 22:24:21 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/331224fb38ef3a2ef7bcc5eadb75...

Powered by Google App Engine
This is Rietveld 408576698