Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2776453002:
Remove spurious condition from LinkLoader::getResourceTypeFromAsAttribute (Closed)
|
Created:
3 years, 9 months ago by Yoav Weiss Modified:
3 years, 8 months ago Reviewers:
droger CC:
chromium-reviews, blink-reviews, gavinp+prerender_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove spurious condition from LinkLoader::getResourceTypeFromAsAttribute
While splitting the "media" `as` value in https://codereview.chromium.org/2732853003/
I accidentally added a spurious condition handling "track".
This CL removes it.
BUG=698521
Review-Url: https://codereview.chromium.org/2776453002
Cr-Commit-Position: refs/heads/master@{#463577}
Committed: https://chromium.googlesource.com/chromium/src/+/a8565f4299ea5c705a629363dd63eb0679722bbc
Patch Set 1 #Patch Set 2 : rebase #Messages
Total messages: 20 (13 generated)
The CQ bit was checked by yoav@yoav.ws to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
yoav@yoav.ws changed reviewers: + droger@chromium.org
Hey droger@, Thanks for spotting that spurious condition. This CL removes it. Mind taking a look?
Thanks, lgtm
Description was changed from ========== Remove spurious condition from LinkLoader::getResourceTypeFromAsAttribute BUG=698521 ========== to ========== Remove spurious condition from LinkLoader::getResourceTypeFromAsAttribute While splitting the "media" `as` value in https://codereview.chromium.org/2732853003/ I accidentally added a spurious condition handling "track". This CL removes it. BUG=698521 ==========
Description was changed from ========== Remove spurious condition from LinkLoader::getResourceTypeFromAsAttribute While splitting the "media" `as` value in https://codereview.chromium.org/2732853003/ I accidentally added a spurious condition handling "track". This CL removes it. BUG=698521 ========== to ========== Remove spurious condition from LinkLoader::getResourceTypeFromAsAttribute While splitting the "media" `as` value in https://codereview.chromium.org/2732853003/ I accidentally added a spurious condition handling "track". This CL removes it. BUG=698521 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2017/03/23 14:42:32, droger wrote: > Thanks, lgtm oops, failed to cq+ this 3 weeks ago.. Let's see if it still applies
The CQ bit was checked by yoav@yoav.ws
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
The CQ bit was checked by yoav@yoav.ws
The patchset sent to the CQ was uploaded after l-g-t-m from droger@chromium.org Link to the patchset: https://codereview.chromium.org/2776453002/#ps20001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491894053589400,
"parent_rev": "226bee734ae45ec8634e1b1d9448cdce97d32290", "commit_rev":
"a8565f4299ea5c705a629363dd63eb0679722bbc"}
Message was sent while issue was closed.
Description was changed from ========== Remove spurious condition from LinkLoader::getResourceTypeFromAsAttribute While splitting the "media" `as` value in https://codereview.chromium.org/2732853003/ I accidentally added a spurious condition handling "track". This CL removes it. BUG=698521 ========== to ========== Remove spurious condition from LinkLoader::getResourceTypeFromAsAttribute While splitting the "media" `as` value in https://codereview.chromium.org/2732853003/ I accidentally added a spurious condition handling "track". This CL removes it. BUG=698521 Review-Url: https://codereview.chromium.org/2776453002 Cr-Commit-Position: refs/heads/master@{#463577} Committed: https://chromium.googlesource.com/chromium/src/+/a8565f4299ea5c705a629363dd63... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/a8565f4299ea5c705a629363dd63... |
