Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 2776433003: [builtins] Implement Array.prototype.reduceRight in the CSA (Closed)

Created:
3 years, 9 months ago by danno
Modified:
3 years, 9 months ago
Reviewers:
mvstanton, Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Implement Array.prototype.reduceRight in the CSA BUG=v8:1956 Review-Url: https://codereview.chromium.org/2776433003 Cr-Commit-Position: refs/heads/master@{#44105} Committed: https://chromium.googlesource.com/v8/v8/+/6141f6e2169f26d0606bee34e2ff9d680eac5d65

Patch Set 1 #

Patch Set 2 : Fix tests #

Patch Set 3 : Remove stray change #

Patch Set 4 : Add back accidental removals #

Patch Set 5 : Add back accidental removals #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -58 lines) Patch
M src/bootstrapper.cc View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M src/builtins/builtins.h View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M src/builtins/builtins-array-gen.cc View 1 2 3 4 9 chunks +83 lines, -15 lines 0 comments Download
M src/code-factory.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M src/code-factory.cc View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
M src/code-stub-assembler.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/code-stub-assembler.cc View 1 2 3 1 chunk +52 lines, -0 lines 0 comments Download
M src/debug/debug-evaluate.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M src/js/array.js View 1 3 chunks +0 lines, -41 lines 0 comments Download
M src/js/typedarray.js View 1 3 chunks +25 lines, -2 lines 0 comments Download

Messages

Total messages: 27 (20 generated)
danno
ptal
3 years, 9 months ago (2017-03-24 08:56:15 UTC) #6
mvstanton
Really nice! LGTM.
3 years, 9 months ago (2017-03-24 09:12:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2776433003/80001
3 years, 9 months ago (2017-03-24 11:53:37 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/37565)
3 years, 9 months ago (2017-03-24 12:00:07 UTC) #20
Yang
On 2017/03/24 12:00:07, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 9 months ago (2017-03-24 12:33:56 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2776433003/80001
3 years, 9 months ago (2017-03-24 13:04:50 UTC) #24
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 13:36:04 UTC) #27
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/v8/v8/+/6141f6e2169f26d0606bee34e2ff9d680ea...

Powered by Google App Engine
This is Rietveld 408576698