Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1364)

Issue 2776433002: Re-enable WebRtcAudioDebugRecordingsBrowserTest.TwoCallsWithAudioDebugRecordings except on Android. (Closed)

Created:
3 years, 9 months ago by Henrik Grunell
Modified:
3 years, 9 months ago
Reviewers:
Guido Urdaneta
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable WebRtcAudioDebugRecordingsBrowserTest.TwoCallsWithAudioDebugRecordings except on Android. Reasons: * According to the comment it fails on Android only. * There's no bug other than the Android failures. * In https://codereview.chromium.org/2764843002/, a fix was made that solved two other failures. If this was failing on other platforms, it may well be fixed now. BUG=NONE Review-Url: https://codereview.chromium.org/2776433002 Cr-Commit-Position: refs/heads/master@{#459722} Committed: https://chromium.googlesource.com/chromium/src/+/67a934df1e818f810151eaea8f5ed1d579fb2ef2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -5 lines) Patch
M content/browser/webrtc/webrtc_audio_debug_recordings_browsertest.cc View 2 chunks +16 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Henrik Grunell
3 years, 9 months ago (2017-03-23 11:49:13 UTC) #3
Henrik Grunell
Ping for review.
3 years, 9 months ago (2017-03-24 10:26:45 UTC) #8
Guido Urdaneta
lgtm
3 years, 9 months ago (2017-03-26 13:07:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2776433002/1
3 years, 9 months ago (2017-03-27 07:55:15 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-27 08:41:01 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/67a934df1e818f810151eaea8f5e...

Powered by Google App Engine
This is Rietveld 408576698