Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2776403002: Revert of Set HexSSID in network config before matching it against policies (Closed)

Created:
3 years, 8 months ago by mdjones
Modified:
3 years, 8 months ago
Reviewers:
stevenjb, Devlin, tbarzic
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Set HexSSID in network config before matching it against policies (patchset #18 id:330001 of https://codereview.chromium.org/2767253006/ ) Reason for revert: Breaking content_browsertests on Marshmallow 64 bit tester: https://uberchromegw.corp.google.com/i/chromium.android/builders/Marshmallow%2064%20bit%20Tester/builds/10654 Original issue's description: > Set HexSSID in network config before matching it against policies > > When creating a new network configuration, the config is matched > against existing, policy configured configs. If the network is already > configured, network configuration should fail. The problem is that > policy matching compares network SSIDs using HexSSID property, which > was not required in the new network config (network configuration > creation would succeed with only SSID set). This CL ensures that the > HexSSID property gets populated before matching the configuration > against existing policies. Also, it adds a step for verifying the > user defined oncconfiguration (in particular that property types are > properly set). > > BUG=705024 > > Review-Url: https://codereview.chromium.org/2767253006 > Cr-Commit-Position: refs/heads/master@{#460018} > Committed: https://chromium.googlesource.com/chromium/src/+/8000869bbcac8cfd3e24de549d8cf07547d152a5 TBR=stevenjb@chromium.org,rdevlin.cronin@chromium.org,tbarzic@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=705024 Review-Url: https://codereview.chromium.org/2776403002 Cr-Commit-Position: refs/heads/master@{#460126} Committed: https://chromium.googlesource.com/chromium/src/+/78d2f5428e959b95e1342a26ace0f29b17493ec3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -307 lines) Patch
M chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M chrome/test/data/extensions/api_test/networking_private/chromeos/test.js View 1 chunk +0 lines, -20 lines 0 comments Download
M chromeos/network/managed_network_configuration_handler_impl.cc View 2 chunks +3 lines, -47 lines 0 comments Download
M extensions/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/api/networking_private/networking_private_chromeos_unittest.cc View 11 chunks +27 lines, -208 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
mdjones
Created Revert of Set HexSSID in network config before matching it against policies
3 years, 8 months ago (2017-03-28 16:39:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2776403002/1
3 years, 8 months ago (2017-03-28 16:40:15 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/78d2f5428e959b95e1342a26ace0f29b17493ec3
3 years, 8 months ago (2017-03-28 16:42:23 UTC) #6
mdjones
3 years, 8 months ago (2017-03-28 20:25:58 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2784643002/ by mdjones@chromium.org.

The reason for reverting is: Relanding since the original patch did not cause
the break..

Powered by Google App Engine
This is Rietveld 408576698