Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 2776393004: Revert of Avoid calling strlen() where possible in base/trace_config (Closed)

Created:
3 years, 8 months ago by imcheng
Modified:
3 years, 8 months ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, oshima+watch_chromium.org, yusukes+watch_chromium.org, vmpstr+watch_chromium.org, wfh+watch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, victorhsieh+watch_chromium.org, tracing+reviews_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Avoid calling strlen() where possible in base/trace_config (patchset #2 id:20001 of https://codereview.chromium.org/2777203004/ ) Reason for revert: Broke WebKit Win x64 Builder (dbg) blink_platform_unittests: WorkQueueTest.BlockedByFenceNewFenceUnblocks WorkQueueTest.TakeTaskFromWorkQueue WorkQueueTest.InsertFenceAfterEnqueueingNonBlocking WorkQueueTest.RemoveFence WorkQueueTest.TakeTaskFromWorkQueue_HitFence WorkQueueTest.InsertNewFence WorkQueueTest.BlockedByFencePop WorkQueueTest.BlockedByFencePopBecomesEmpty https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.webkit%2FWebKit_Win_x64_Builder__dbg_%2F106650%2F%2B%2Frecipes%2Fsteps%2Fblink_platform_unittests%2F0%2Fstdout Original issue's description: > The main target of this CL is to avoid calling strlen() where possible. > It can happen if a raw |char*| literal or result of |c_str()| function is used > to construct a StringPiece or std::string objects. > In addition, StringPiece API like SplitStringPiece was used to avoid > unnecessary string copying and allocations. > > BUG=679479 > > Review-Url: https://codereview.chromium.org/2777203004 > Cr-Commit-Position: refs/heads/master@{#460203} > Committed: https://chromium.googlesource.com/chromium/src/+/b5d44bb49fd4dc5e544f4312de6b00b1a1eb625c TBR=primiano@chromium.org,yusukes@chromium.org,iceman@yandex-team.ru # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=679479 Review-Url: https://codereview.chromium.org/2776393004 Cr-Commit-Position: refs/heads/master@{#460223} Committed: https://chromium.googlesource.com/chromium/src/+/dbec06a1bfb0204b72ebd11fafd0885792197043

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -34 lines) Patch
M base/trace_event/trace_config.h View 2 chunks +2 lines, -2 lines 0 comments Download
M base/trace_event/trace_config.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/trace_event/trace_config_category_filter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M base/trace_event/trace_config_category_filter.cc View 5 chunks +18 lines, -17 lines 0 comments Download
M base/trace_event/trace_event_etw_export_win.h View 2 chunks +2 lines, -2 lines 0 comments Download
M base/trace_event/trace_event_etw_export_win.cc View 4 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/arc/tracing/arc_tracing_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
imcheng
Created Revert of Avoid calling strlen() where possible in base/trace_config
3 years, 8 months ago (2017-03-28 22:13:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2776393004/1
3 years, 8 months ago (2017-03-28 22:14:15 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 22:16:46 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dbec06a1bfb0204b72ebd11fafd0...

Powered by Google App Engine
This is Rietveld 408576698