DescriptionRevert of Avoid calling strlen() where possible in base/trace_config (patchset #2 id:20001 of https://codereview.chromium.org/2777203004/ )
Reason for revert:
Broke WebKit Win x64 Builder (dbg)
blink_platform_unittests:
WorkQueueTest.BlockedByFenceNewFenceUnblocks
WorkQueueTest.TakeTaskFromWorkQueue
WorkQueueTest.InsertFenceAfterEnqueueingNonBlocking
WorkQueueTest.RemoveFence
WorkQueueTest.TakeTaskFromWorkQueue_HitFence
WorkQueueTest.InsertNewFence
WorkQueueTest.BlockedByFencePop
WorkQueueTest.BlockedByFencePopBecomesEmpty
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.webkit%2FWebKit_Win_x64_Builder__dbg_%2F106650%2F%2B%2Frecipes%2Fsteps%2Fblink_platform_unittests%2F0%2Fstdout
Original issue's description:
> The main target of this CL is to avoid calling strlen() where possible.
> It can happen if a raw |char*| literal or result of |c_str()| function is used
> to construct a StringPiece or std::string objects.
> In addition, StringPiece API like SplitStringPiece was used to avoid
> unnecessary string copying and allocations.
>
> BUG=679479
>
> Review-Url: https://codereview.chromium.org/2777203004
> Cr-Commit-Position: refs/heads/master@{#460203}
> Committed: https://chromium.googlesource.com/chromium/src/+/b5d44bb49fd4dc5e544f4312de6b00b1a1eb625c
TBR=primiano@chromium.org,yusukes@chromium.org,iceman@yandex-team.ru
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=679479
Review-Url: https://codereview.chromium.org/2776393004
Cr-Commit-Position: refs/heads/master@{#460223}
Committed: https://chromium.googlesource.com/chromium/src/+/dbec06a1bfb0204b72ebd11fafd0885792197043
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|