Give the BackgroundFetchJobController a simple state.

Give the BackgroundFetchJobController a simple state.

This helps determine "where we are" and will reduce flakiness because we
get more control over when the Job Controller is considered active.

BUG=

Review-Url: https://codereview.chromium.org/2776353004
Cr-Commit-Position: refs/heads/master@{#460379}
Committed: https://chromium.googlesource.com/chromium/src/+/8f6e0b40224c447d0968fd1a639d666d800c36a6

[Peter Beverloo, 2017-03-28 14:46:26]

peter@chromium.org changed reviewers:
+ harkness@chromium.org

[Peter Beverloo, 2017-03-28 14:46:27]

+harkness

[harkness, 2017-03-28 14:55:43]

LGTM

https://codereview.chromium.org/2776353004/diff/1/content/browser/background_...
File content/browser/background_fetch/background_fetch_context.cc (right):

https://codereview.chromium.org/2776353004/diff/1/content/browser/background_...
content/browser/background_fetch/background_fetch_context.cc:141: // event to
the Service Worker when |aborted_by_developer| is not set.
remove |aborted_by_developer| from comment.

https://codereview.chromium.org/2776353004/diff/1/content/browser/background_...
File content/browser/background_fetch/background_fetch_job_controller.h (right):

https://codereview.chromium.org/2776353004/diff/1/content/browser/background_...
content/browser/background_fetch/background_fetch_job_controller.h:36:
base::OnceCallback<void(BackgroundFetchJobController*)>;
optional: personally, I would have this callback return registrationId and
state, since the first thing the caller does is query for registrationId and
state, and we can look up the JobController given the registrationId.

[Peter Beverloo, 2017-03-29 13:05:22]

Thanks!

https://codereview.chromium.org/2776353004/diff/1/content/browser/background_...
File content/browser/background_fetch/background_fetch_context.cc (right):

https://codereview.chromium.org/2776353004/diff/1/content/browser/background_...
content/browser/background_fetch/background_fetch_context.cc:141: // event to
the Service Worker when |aborted_by_developer| is not set.
On 2017/03/28 14:55:43, harkness wrote:
> remove |aborted_by_developer| from comment.

Done.

https://codereview.chromium.org/2776353004/diff/1/content/browser/background_...
File content/browser/background_fetch/background_fetch_job_controller.h (right):

https://codereview.chromium.org/2776353004/diff/1/content/browser/background_...
content/browser/background_fetch/background_fetch_job_controller.h:36:
base::OnceCallback<void(BackgroundFetchJobController*)>;
On 2017/03/28 14:55:43, harkness wrote:
> optional: personally, I would have this callback return registrationId and
> state, since the first thing the caller does is query for registrationId and
> state, and we can look up the JobController given the registrationId.

I'm keeping this as-is for now. We can reduce the given information later if we
can, which I'd be in favor of, but depending on where we take the JobController
that may still change. Let's iterate on it as part of the other CL.

[Peter Beverloo, 2017-03-29 13:05:28]

The CQ bit was checked by peter@chromium.org

[Peter Beverloo, 2017-03-29 13:05:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
harkness@chromium.org
Link to the patchset: https://codereview.chromium.org/2776353004/#ps20001
(title: "comment")

[commit-bot: I haz the power, 2017-03-29 13:05:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 13:45:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 13:45:14]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Peter Beverloo, 2017-03-29 13:47:03]

The CQ bit was checked by peter@chromium.org

[commit-bot: I haz the power, 2017-03-29 13:47:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 14:29:28]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490795223930780,
"parent_rev": "57a65c934af9dce077f720e6fc8a7579de79924f", "commit_rev":
"8f6e0b40224c447d0968fd1a639d666d800c36a6"}

[commit-bot: I haz the power, 2017-03-29 14:30:15]

Description was changed from

==========
Give the BackgroundFetchJobController a simple state.

This helps determine "where we are" and will reduce flakiness because we
get more control over when the Job Controller is considered active.

BUG=
==========

to

==========
Give the BackgroundFetchJobController a simple state.

This helps determine "where we are" and will reduce flakiness because we
get more control over when the Job Controller is considered active.

BUG=

Review-Url: https://codereview.chromium.org/2776353004
Cr-Commit-Position: refs/heads/master@{#460379}
Committed:
https://chromium.googlesource.com/chromium/src/+/8f6e0b40224c447d0968fd1a639d...
==========

[commit-bot: I haz the power, 2017-03-29 14:30:16]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8f6e0b40224c447d0968fd1a639d...