Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2776313004: Add comment on TBR'ing GN bootstrap changes. (Closed)

Created:
3 years, 8 months ago by brettw
Modified:
3 years, 8 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, Dirk Pranke, tfarina, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add comment on TBR'ing GN bootstrap changes. It should be clear that people can TBR certain types of updates to the bootstrap script. Review-Url: https://codereview.chromium.org/2776313004 Cr-Commit-Position: refs/heads/master@{#460444} Committed: https://chromium.googlesource.com/chromium/src/+/b17ee3d6890cf542ff39366a5f6579d540314829

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tools/gn/bootstrap/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
brettw
3 years, 8 months ago (2017-03-29 17:19:52 UTC) #2
Paweł Hajdan Jr.
LGTM, thanks!
3 years, 8 months ago (2017-03-29 17:20:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2776313004/1
3 years, 8 months ago (2017-03-29 17:26:55 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 17:41:13 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b17ee3d6890cf542ff39366a5f65...

Powered by Google App Engine
This is Rietveld 408576698