Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2776293003: Revert of [regexp] Named capture support for string replacements (Closed)

Created:
3 years, 8 months ago by jgruber
Modified:
3 years, 8 months ago
Reviewers:
Dan Ehrenberg, Yang
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [regexp] Named capture support for string replacements (patchset #5 id:80001 of https://codereview.chromium.org/2775303002/ ) Reason for revert: Invalid DCHECKs for non-matched groups. Original issue's description: > [regexp] Named capture support for string replacements > > This implements support for named captures in > RegExp.prototype[@@replace] for when the replaceValue is not callable. > > Named captures can be referenced from replacement strings by using the > "$<name>" syntax. A couple of examples: > > let re = /(?<fst>.)(?<snd>.)/u; > "abcd".replace(re, "$<snd>$<fst>") // "bacd" > "abcd".replace(re, "$2$1") // "bacd" (numbered refs work as always) > "abcd".replace(re, "$<snd") // SyntaxError (unterminated named ref) > "abcd".replace(re, "$<42$1>") // "cd" (invalid name) > "abcd".replace(re, "$<thd>") // "cd" (non-existent name) > "abcd".replace(/(?<fst>.)|(?<snd>.)/u, "$<snd>") // "cd" (non-matched capture) > > Support is currently behind the --harmony-regexp-named-captures flag. > > BUG=v8:5437 > > Review-Url: https://codereview.chromium.org/2775303002 > Cr-Commit-Position: refs/heads/master@{#44171} > Committed: https://chromium.googlesource.com/v8/v8/+/17f13863b64b25eccf565e0aa9c4c441f0562b84 TBR=yangguo@chromium.org,littledan@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5437 Review-Url: https://codereview.chromium.org/2776293003 Cr-Commit-Position: refs/heads/master@{#44180} Committed: https://chromium.googlesource.com/v8/v8/+/34ffdd6238fb2aa3beb7a9397521e56b48b04523

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -373 lines) Patch
M src/messages.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/objects.h View 4 chunks +2 lines, -13 lines 0 comments Download
M src/objects.cc View 3 chunks +0 lines, -42 lines 0 comments Download
M src/runtime/runtime-regexp.cc View 20 chunks +55 lines, -242 lines 0 comments Download
M src/runtime/runtime-strings.cc View 1 chunk +3 lines, -10 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ForAwaitOf.golden View 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ForOf.golden View 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Generators.golden View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/regexp-named-captures.js View 1 chunk +0 lines, -56 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
jgruber
Created Revert of [regexp] Named capture support for string replacements
3 years, 8 months ago (2017-03-28 09:02:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2776293003/1
3 years, 8 months ago (2017-03-28 09:02:08 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 09:02:22 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/34ffdd6238fb2aa3beb7a9397521e56b48b...

Powered by Google App Engine
This is Rietveld 408576698