Refresh ChromeVox options page CSS

chrome/browser/resources/chromeos/chromevox/chromevox/background/options.js

Index: chrome/browser/resources/chromeos/chromevox/chromevox/background/options.js
diff --git a/chrome/browser/resources/chromeos/chromevox/chromevox/background/options.js b/chrome/browser/resources/chromeos/chromevox/chromevox/background/options.js
index 53fc20aa6191e7f457f80449809fe4aa64b6068e..35d3ac6c38b213723a62fdfcd84ad56d80517f83 100644
--- a/chrome/browser/resources/chromeos/chromevox/chromevox/background/options.js
+++ b/chrome/browser/resources/chromeos/chromevox/chromevox/background/options.js
@@ -277,26 +277,18 @@ cvox.OptionsPage.populateBrailleTablesSelect = function() {
   var updateTableType = function(setFocus) {
     var currentTableType = localStorage['brailleTableType'] || 'brailleTable6';
     if (currentTableType == 'brailleTable6') {
-      select6.removeAttribute('aria-hidden');
-      select6.setAttribute('tabIndex', 0);
-      select6.style.display = 'block';
+      select6.parentElement.style.display = 'block';
+      select8.parentElement.style.display = 'none';
       if (setFocus) {
         select6.focus();
       }
-      select8.setAttribute('aria-hidden', 'true');
-      select8.setAttribute('tabIndex', -1);
-      select8.style.display = 'none';
       localStorage['brailleTable'] = localStorage['brailleTable6'];
       localStorage['brailleTableType'] = 'brailleTable6';
       tableTypeButton.textContent =
           Msgs.getMsg('options_braille_table_type_6');
     } else {
-      select6.setAttribute('aria-hidden', 'true');
-      select6.setAttribute('tabIndex', -1);
-      select6.style.display = 'none';
-      select8.removeAttribute('aria-hidden');
-      select8.setAttribute('tabIndex', 0);

[David Tseng, 2017/03/28 01:04:26]

They you test this with the tab key? It was a little tricky to make the hidden
element gone and unreachable via ChromeVox navigation. Furthermore, remember we
still are supporting Classic.

[dmazzoni, 2017/03/28 17:28:28]

I tested this with Tab and with ChromeVox navigation,
and with Classic also. Setting display:none on the ancestor
works fine, there shouldn't be any reason to also set the
tabIndex.

-      select8.style.display = 'block';
+      select6.parentElement.style.display = 'none';
+      select8.parentElement.style.display = 'block';
       if (setFocus) {
         select8.focus();
       }