Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2232)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/resources/chromeos/chromevox/chromevox/background/options.html

Issue 2776293002: Refresh ChromeVox options page CSS (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/chromevox/background/options.css ('k') | chrome/browser/resources/chromeos/chromevox/chromevox/background/options.js » ('j') | chrome/browser/resources/chromeos/chromevox/chromevox/background/options.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/chromeos/chromevox/chromevox/background/options.html
diff --git a/chrome/browser/resources/chromeos/chromevox/chromevox/background/options.html b/chrome/browser/resources/chromeos/chromevox/chromevox/background/options.html
index 108a3c944272f5e6e6e8c40be918c9bbca4e5206..840da200cf86102b2ef96978fc270e52476883a5 100644
--- a/chrome/browser/resources/chromeos/chromevox/chromevox/background/options.html
+++ b/chrome/browser/resources/chromeos/chromevox/chromevox/background/options.html
@@ -5,11 +5,8 @@
<head>
<title class="i18n" msgid="options_page_title">ChromeVox Options</title>
-<link rel="stylesheet" type="text/css" href="chrome_shared2.css" />
-<link rel="stylesheet" type="text/css" href="options_widgets.css" />
<link rel="stylesheet" type="text/css" href="options.css" />
-
<script type="text/javascript" src="../../closure/base.js"></script>
<script type="text/javascript" src="../../deps.js"></script>
<script type="text/javascript" src="options_loader.js"></script>
@@ -20,32 +17,37 @@
<html>
<body>
-<div>
- <!-- The "with dev msgs" in the title helps when debugging problems with the message
- replacer. -->
+ <!--
+ The "with dev msgs" in the title helps when debugging problems
+ with the message replacer.
+ -->
<h1 class="i18n" msgid="options_page_title">ChromeVox (with dev msgs)</h1>
- <p id="version"></p>
+ <div class="container">
+
+ <p id="version"></p>
<div class="option">
- <input id="useVerboseMode" type="checkbox" class="checkbox pref" name="useVerboseMode" />
+ <input id="useVerboseMode" type="checkbox" class="checkbox pref"
+ name="useVerboseMode">
<label for="useVerboseMode" class="i18n" msgid="options_verbosity_verbose">
Enable verbose descriptions.
</label>
</div>
<div class="option">
- <input id="autoRead" type="checkbox" class="checkbox pref" name="autoRead"></input>
+ <input id="autoRead" type="checkbox" class="checkbox pref" name="autoRead">
<label for="autoRead" class="i18n" msgid="options_auto_read">
Automatically read a page after it finishes loading.
</label>
</div>
- <p class="i18n description" msgid="options_audio_description" id="audioDescription">
+ <h2 class="i18n description" msgid="options_audio_description"
+ id="audioDescription">
When playing audio
- </p>
+ </h2>
- <div>
+ <div class="option">
<select id="audioStrategy" class="pref" aria-labelledby="audioDescription">
<option id="audioNormal" class="i18n" msgid="options_audio_normal">
play at normal volume even if ChromeVox is speaking
@@ -60,61 +62,74 @@
</div>
<h2 class="i18n" msgid="options_voices">Voices</h2>
- <p class="i18n description" msgid="options_voices_description" id="voices_description">
- Change the current voice by selecting an option from the list below.
- </p>
-
- <div>
+ <div class="option">
+ <span class="i18n description" msgid="options_voices_description"
+ id="voices_description">
+ Current voice:
+ </span>
<select id="voices" aria-labelledby="voices_description"></select>
- <br><br>
</div>
-
<h2 class="chromeos i18n" msgid="options_braille">Braille</h2>
- <div class="chromeos">
- <p class="i18n description" msgid="options_braille_description_6" id="braille_description_6">
- Change the current 6 dot braille table by selecting an option from the list below.
- </p>
+ <div class="chromeos option">
+ <span class="i18n description" msgid="options_braille_description_6"
+ id="braille_description_6">
+ 6-dot braille table:
+ </span>
<select id="brailleTable6" aria-labelledby="braille_description_6"></select>
- <p class="i18n description" msgid="options_braille_description_8" id="braille_description_8">
- Change the current 8 dot braille table by selecting an option from the list below.
- </p>
+ </div>
+ <div class="chromeos option">
+ <span class="i18n description" msgid="options_braille_description_8"
+ id="braille_description_8">
+ 8-dot braille table:
David Tseng 2017/03/28 01:04:26 Select an 8-dot braille table: (you're mixing lab
dmazzoni 2017/03/28 17:28:27 Done.
+ </span>
<select id="brailleTable8" aria-labelledby="braille_description_8"></select>
- <button id="brailleTableType"></button>
- <div class="option">
- <label>
- <input id="brailleWordWrap" type="checkbox" class="checkbox pref" name="brailleWordWrap" />
- <span class="i18n" msgid="options_braille_word_wrap">
- Enable word wrap
- </span>
- </label>
- </div>
- <br><br>
+ </div>
+ <div class="chromeos option">
+ <button id="brailleTableType"></button><span>&nbsp;</span>
+ </div>
+ <div class="chromeos option">
+ <label>
+ <input id="brailleWordWrap" type="checkbox" class="checkbox pref"
+ name="brailleWordWrap">
+ <span class="i18n" msgid="options_braille_word_wrap">
+ Enable word wrap
+ </span>
+ </label>
</div>
- <h2 class="i18n" msgid="options_virtual_braille_display">Virtual Braille Display</h2>
+ <h2 class="i18n" msgid="options_virtual_braille_display">
+ Virtual Braille Display
David Tseng 2017/03/28 01:04:26 Btw, I think this deserves a descriptive label e.g
dmazzoni 2017/03/28 17:28:27 Done.
+ </h2>
+ <div class="option">
<label>
- <div>
- <span class="i18n description" msgid="options_virtual_braille_display_rows" id="virtual_braille_display_rows_description">
+ <span class="i18n description" msgid="options_virtual_braille_display_rows"
+ id="virtual_braille_display_rows_description">
Rows:
</span>
- </div>
<input type="number" min="1" id="virtual_braille_display_rows_input">
</label>
- <label >
- <div>
- <span class="i18n description" msgid="options_virtual_braille_display_columns" id="virtual_braille_display_columns_description">
+ </div>
+ <div class="option">
+ <label>
+ <span class="i18n description"
+ msgid="options_virtual_braille_display_columns"
+ id="virtual_braille_display_columns_description">
Columns:
David Tseng 2017/03/28 01:04:26 Imo, rows and columns are very "dev" terms. Why no
dmazzoni 2017/03/28 17:28:27 Done.
</span>
- </div>
<input type="number" min="1" id="virtual_braille_display_columns_input">
</label>
+ </div>
- <div id="currentDisplayStyle"></div>
- <button id="changeDisplayStyle"></button>
+ <div class="option">
+ <span id="currentDisplayStyle"></span>
+ <button id="changeDisplayStyle"></button>
+ </div>
<div id="status" role="live" aria-live="assertive">
</div>
-</div>
+
+ </div>
+
</body>
</html>
« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/chromevox/background/options.css ('k') | chrome/browser/resources/chromeos/chromevox/chromevox/background/options.js » ('j') | chrome/browser/resources/chromeos/chromevox/chromevox/background/options.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698