Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2776283002: User orientation lock (Closed)

Created:
3 years, 9 months ago by oshima
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews, extensions-reviews_chromium.org, sadrul, mlamouri+watch-screen-orientation_chromium.org, jam, darin-cc_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, kalyank, davemoore+watch_chromium.org
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

User orientation lock * Added user locked orientation. Once it's locked, the orientation will be used as a preferred orientation. - If the active appilcation's orientation is any, the user locked orientation will be used. - If the active appilcation's orientation is specified, the user locked orientation will be ignored and uses the application's orientation. * Exclude windows that does not have AppType because they do not control orientation into account. For example, task manager, app list shouldn't affect orientation. * added ScreenOrientationControllerTestApi Next steps: - landscape / portrait app should lock to secondary/primary. - remember and restore the locked state. - handle rotation change from chrome.system.display api. - Add portrait/landscape lock icon and make UI consistent with Android rotation lock UI. BUG=683456 TEST=manual, unitt tests Review-Url: https://codereview.chromium.org/2757493002 Cr-Commit-Position: refs/heads/master@{#459291} (cherry picked from commit a5176fd790a6ccc800274a4135dbdc7476deac88) (cherry picked from commit a85beb49b1025a0430f5886c60b4d8768ef66352) Review-Url: https://codereview.chromium.org/2776283002 . Cr-Commit-Position: refs/branch-heads/3029@{#436} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/3ff47417a996e5b5afd777dc385809d6372d42b2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+427 lines, -105 lines) Patch
M ash/content/display/screen_orientation_controller_chromeos_unittest.cc View 22 chunks +176 lines, -32 lines 0 comments Download
M ash/display/screen_orientation_controller_chromeos.h View 5 chunks +27 lines, -10 lines 0 comments Download
M ash/display/screen_orientation_controller_chromeos.cc View 9 chunks +117 lines, -40 lines 0 comments Download
M ash/system/chromeos/rotation/tray_rotation_lock.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/rotation/tray_rotation_lock.cc View 8 chunks +13 lines, -12 lines 0 comments Download
M ash/system/chromeos/rotation/tray_rotation_lock_unittest.cc View 3 chunks +9 lines, -6 lines 0 comments Download
M ash/test/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M ash/test/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
A ash/test/screen_orientation_controller_test_api.h View 1 chunk +38 lines, -0 lines 0 comments Download
A ash/test/screen_orientation_controller_test_api.cc View 1 chunk +32 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/display/display_preferences_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/display_info_provider_chromeos_unittest.cc View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
oshima
3 years, 9 months ago (2017-03-27 19:14:47 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3ff47417a996e5b5afd777dc385809d6372d42b2.

Powered by Google App Engine
This is Rietveld 408576698