Chromium Code Reviews
DescriptionUser orientation lock
* Added user locked orientation.
Once it's locked, the orientation will be used as a preferred orientation.
- If the active appilcation's orientation is any, the user locked orientation will be used.
- If the active appilcation's orientation is specified, the user locked orientation will be ignored
and uses the application's orientation.
* Exclude windows that does not have AppType because they do not control orientation into account.
For example, task manager, app list shouldn't affect orientation.
* added ScreenOrientationControllerTestApi
Next steps:
- landscape / portrait app should lock to secondary/primary.
- remember and restore the locked state.
- handle rotation change from chrome.system.display api.
- Add portrait/landscape lock icon and make UI consistent with Android rotation lock UI.
BUG=683456
TEST=manual, unitt tests
Review-Url: https://codereview.chromium.org/2757493002
Cr-Commit-Position: refs/heads/master@{#459291}
(cherry picked from commit a5176fd790a6ccc800274a4135dbdc7476deac88)
(cherry picked from commit a85beb49b1025a0430f5886c60b4d8768ef66352)
Review-Url: https://codereview.chromium.org/2776283002 .
Cr-Commit-Position: refs/branch-heads/3029@{#436}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Committed: https://chromium.googlesource.com/chromium/src/+/3ff47417a996e5b5afd777dc385809d6372d42b2
Patch Set 1 #Messages
Total messages: 2 (1 generated)
|