Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2776263003: [regexp] Handle unmatched groups in callable replacers (Closed)

Created:
3 years, 8 months ago by jgruber
Modified:
3 years, 8 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Handle unmatched groups in callable replacers BUG=v8:5437 Review-Url: https://codereview.chromium.org/2776263003 Cr-Commit-Position: refs/heads/master@{#44194} Committed: https://chromium.googlesource.com/v8/v8/+/19f626f076cc908cb90f23f514126c38a9d87a36

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M src/runtime/runtime-regexp.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/regexp-named-captures.js View 5 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
jgruber
3 years, 8 months ago (2017-03-28 12:17:19 UTC) #8
Yang
On 2017/03/28 12:17:19, jgruber wrote: lgtm
3 years, 8 months ago (2017-03-28 13:25:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2776263003/20001
3 years, 8 months ago (2017-03-28 13:28:09 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 13:29:29 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/19f626f076cc908cb90f23f514126c38a9d...

Powered by Google App Engine
This is Rietveld 408576698