Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 2776243003: Make media notification classes configurable (Closed)

Created:
3 years, 8 months ago by Zhiqiang Zhang (Slow)
Modified:
3 years, 8 months ago
Reviewers:
whywhat
CC:
agrieve+watch_chromium.org, chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make media notification classes configurable This CL makes the media notification classes configurable in the following ways: * Using Class<?> instead of class names for simplicity. * Having a static map in MediaNotificationManager to look up the service class, receiver class, notification group name for a given notification ID. BUG=705925 Review-Url: https://codereview.chromium.org/2776243003 Cr-Commit-Position: refs/heads/master@{#460394} Committed: https://chromium.googlesource.com/chromium/src/+/52ec59e6f64784544c395fba8c448fea01033de4

Patch Set 1 #

Patch Set 2 : bundle options together #

Total comments: 2

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -59 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaButtonReceiver.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java View 1 2 12 chunks +58 lines, -57 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Zhiqiang Zhang (Slow)
3 years, 8 months ago (2017-03-28 12:40:11 UTC) #2
whywhat
lgtm I'm not so sure it's worth it to keep the map in the static ...
3 years, 8 months ago (2017-03-28 19:35:02 UTC) #3
Zhiqiang Zhang (Slow)
On 2017/03/28 at 19:35:02, avayvod wrote: > lgtm > > I'm not so sure it's ...
3 years, 8 months ago (2017-03-29 14:16:51 UTC) #4
Zhiqiang Zhang (Slow)
https://codereview.chromium.org/2776243003/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java File chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java (right): https://codereview.chromium.org/2776243003/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java#newcode604 chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java:604: mNotificationId = notificationId; On 2017/03/28 at 19:35:02, whywhat wrote: ...
3 years, 8 months ago (2017-03-29 14:17:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2776243003/40001
3 years, 8 months ago (2017-03-29 14:45:35 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 15:27:20 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/52ec59e6f64784544c395fba8c44...

Powered by Google App Engine
This is Rietveld 408576698