Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2776203003: Revert of [Offline Pages] Add Android version check for timeout in offliner policy. (Closed)

Created:
3 years, 9 months ago by romax
Modified:
3 years, 9 months ago
Reviewers:
Pete Williamson
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Offline Pages] Add Android version check for timeout in offliner policy. (patchset #4 id:80001 of https://codereview.chromium.org/2755753005/ ) Reason for revert: As described in the bug by fgorski@, we shouldn't go longer than 3 minutes since that's the timeout on GCMNetworkManager. Original issue's description: > [Offline Pages] Add Android version check for timeout in offliner policy. > > Since the doze mode only exists after Android 6.0, adding a check in order > to change to a longer timeout when the system has no doze mode. > > BUG=701035 > > Review-Url: https://codereview.chromium.org/2755753005 > Cr-Commit-Position: refs/heads/master@{#459274} > Committed: https://chromium.googlesource.com/chromium/src/+/15a0b4f782f55474f51b073f583a974b5f2bf63f TBR=petewil@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=701035 Review-Url: https://codereview.chromium.org/2776203003 Cr-Commit-Position: refs/heads/master@{#459836} Committed: https://chromium.googlesource.com/chromium/src/+/3321d7f0ab6782ed8e316e5b94b21aad2c77a603

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -55 lines) Patch
M components/offline_pages/core/background/offliner_policy.h View 6 chunks +12 lines, -32 lines 0 comments Download
M components/offline_pages/core/background/pick_request_task_unittest.cc View 7 chunks +19 lines, -18 lines 0 comments Download
M components/offline_pages/core/background/request_coordinator_unittest.cc View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
romax
Created Revert of [Offline Pages] Add Android version check for timeout in offliner policy.
3 years, 9 months ago (2017-03-27 17:33:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2776203003/1
3 years, 9 months ago (2017-03-27 17:34:38 UTC) #3
Pete Williamson
lgtm
3 years, 9 months ago (2017-03-27 17:40:13 UTC) #4
commit-bot: I haz the power
3 years, 9 months ago (2017-03-27 18:30:03 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3321d7f0ab6782ed8e316e5b94b2...

Powered by Google App Engine
This is Rietveld 408576698