third_party/WebKit/Source/core/svg/properties/SVGListPropertyHelper.h - Issue 2776203002: Migrate WTF::Vector::remove() to ::erase()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/properties/SVGListPropertyHelper.h

Issue 2776203002: Migrate WTF::Vector::remove() to ::erase() (Closed)

Patch Set: rebase, repatch VectorTest Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/svg/animation/SVGSMILElement.cpp ('k') | third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/svg/properties/SVGListPropertyHelper.h

diff --git a/third_party/WebKit/Source/core/svg/properties/SVGListPropertyHelper.h b/third_party/WebKit/Source/core/svg/properties/SVGListPropertyHelper.h

index 19f8ac5179a83e7e012e869829a762b012708db4..120e0e2c7154b9bcb851d2c37d4baa949c4460eb 100644

--- a/third_party/WebKit/Source/core/svg/properties/SVGListPropertyHelper.h

+++ b/third_party/WebKit/Source/core/svg/properties/SVGListPropertyHelper.h

@@ -235,7 +235,7 @@ ItemProperty* SVGListPropertyHelper<Derived, ItemProperty>::removeItem(

}

DCHECK_EQ(m_values.at(index)->ownerList(), this);

ItemPropertyType* oldItem = m_values.at(index);

- m_values.remove(index);

+ m_values.erase(index);

oldItem->setOwnerList(0);

return oldItem;

}