Change CSSParserContext to either take explicit or implicit referrer

Change CSSParserContext to either take explicit or implicit referrer

Either we pass in an base URL, then also pass in a referrer policy, or
we pass in a document, the take both from the document.

BUG=676645
R=estark@chromium.org

Review-Url: https://codereview.chromium.org/2776163002
Cr-Commit-Position: refs/heads/master@{#460068}
Committed: https://chromium.googlesource.com/chromium/src/+/d687e467ebbde1d0c7862c29a375263167b04306

[jochen (gone - plz use gerrit), 2017-03-27 18:33:51]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 18:35:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 19:45:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 19:45:40]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[jochen (gone - plz use gerrit), 2017-03-28 07:14:57]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 07:15:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 08:33:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 08:33:04]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jochen (gone - plz use gerrit), 2017-03-28 10:37:44]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 10:37:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[estark, 2017-03-28 11:02:34]

lgtm with a question inline

https://codereview.chromium.org/2776163002/diff/50001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/StyleRuleImport.cpp (right):

https://codereview.chromium.org/2776163002/diff/50001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/StyleRuleImport.cpp:84: :
context->referrer().referrerPolicy,
This looks like it will result in a different referrer in certain cases; for
example in the case where |m_parentStyleSheet| is null, we would previously end
up with CSSParserContext having referrer ("", ReferrerPolicyDefault), but now
it'll be (|baseURL|, ReferrerPolicyDefault), meaning we'll send non-empty
referrers in cases where we weren't previously. Is that correct and/or
intentional?

[jochen (gone - plz use gerrit), 2017-03-28 11:21:23]

https://codereview.chromium.org/2776163002/diff/50001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/StyleRuleImport.cpp (right):

https://codereview.chromium.org/2776163002/diff/50001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/StyleRuleImport.cpp:84: :
context->referrer().referrerPolicy,
On 2017/03/28 at 11:02:34, estark wrote:
> This looks like it will result in a different referrer in certain cases; for
example in the case where |m_parentStyleSheet| is null, we would previously end
up with CSSParserContext having referrer ("", ReferrerPolicyDefault), but now
it'll be (|baseURL|, ReferrerPolicyDefault), meaning we'll send non-empty
referrers in cases where we weren't previously. Is that correct and/or
intentional?

good point.

I think it's correct(er) now. If we have a baseURL (here, the response().url()
from loading the stylesheet), we should use it as referrer (according to my
proposed spec change :) )

[commit-bot: I haz the power, 2017-03-28 12:35:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 12:35:33]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2017-03-28 12:36:08]

The CQ bit was checked by jochen@chromium.org

[commit-bot: I haz the power, 2017-03-28 12:36:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 12:40:47]

CQ is committing da patch.

Bot data: {"patchset_id": 50001, "attempt_start_ts": 1490704568736560,
"parent_rev": "09fdd7696d0f20abd9984f23e0fd1aadd5e2f93b", "commit_rev":
"d687e467ebbde1d0c7862c29a375263167b04306"}

[commit-bot: I haz the power, 2017-03-28 12:41:27]

Description was changed from

==========
Change CSSParserContext to either take explicit or implicit referrer

Either we pass in an base URL, then also pass in a referrer policy, or
we pass in a document, the take both from the document.

BUG=676645
R=estark@chromium.org
==========

to

==========
Change CSSParserContext to either take explicit or implicit referrer

Either we pass in an base URL, then also pass in a referrer policy, or
we pass in a document, the take both from the document.

BUG=676645
R=estark@chromium.org

Review-Url: https://codereview.chromium.org/2776163002
Cr-Commit-Position: refs/heads/master@{#460068}
Committed:
https://chromium.googlesource.com/chromium/src/+/d687e467ebbde1d0c7862c29a375...
==========

[commit-bot: I haz the power, 2017-03-28 12:41:29]

Committed patchset #4 (id:50001) as
https://chromium.googlesource.com/chromium/src/+/d687e467ebbde1d0c7862c29a375...