Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2776103003:
Unskipped csp/navigation test and removed duplicate local test (Closed)
DescriptionUnskipped csp/navigation test and removed duplicate local test
BUG=694525
Review-Url: https://codereview.chromium.org/2776103003
Cr-Commit-Position: refs/heads/master@{#460342}
Committed: https://chromium.googlesource.com/chromium/src/+/1690551c93020ef0ebee1e0a1a523c089ce3d62f
Patch Set 1 #Patch Set 2 : Rebase-update #Patch Set 3 : Fixed previous patch merge screw ups #
Messages
Total messages: 22 (15 generated)
The CQ bit was checked by andypaicu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
andypaicu@chromium.org changed reviewers: + mkwst@chromium.org
There is another navigation test in our local tests: http/tests/security/contentSecurityPolicy/frame-src-child-frame-navigates-to-blocked-origin.html but it seems to me like that test is not ready yet according to the assert comments.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2017/03/27 at 11:59:31, andypaicu wrote: > There is another navigation test in our local tests: > > http/tests/security/contentSecurityPolicy/frame-src-child-frame-navigates-to-blocked-origin.html > > but it seems to me like that test is not ready yet according to the assert comments. What do you mean? This patch LGTM regardless, but it would be good to dedupe our local tests.
On 2017/03/28 at 10:20:05, mkwst wrote: > On 2017/03/27 at 11:59:31, andypaicu wrote: > > There is another navigation test in our local tests: > > > > http/tests/security/contentSecurityPolicy/frame-src-child-frame-navigates-to-blocked-origin.html > > > > but it seems to me like that test is not ready yet according to the assert comments. > > What do you mean? > > This patch LGTM regardless, but it would be good to dedupe our local tests. Well it makes these asserts: assert_equals(e.blockedURI, "http://localhost:8000", "The reported URL should be stripped."); assert_equals(e.lineNumber, 7, "This shouldn't actually be 7, since it happens in a cross-origin frame. :/"); The comments on them seem to contradict the actual assertions so the only thing I can think of is that they're written for functionality that's not ready yet.
The CQ bit was checked by andypaicu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
The CQ bit was checked by andypaicu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by andypaicu@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org Link to the patchset: https://codereview.chromium.org/2776103003/#ps40001 (title: "Fixed previous patch merge screw ups")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490783916880000,
"parent_rev": "1158128600dde88aff49d300f07a0ac5da1ea6f6", "commit_rev":
"1690551c93020ef0ebee1e0a1a523c089ce3d62f"}
Message was sent while issue was closed.
Description was changed from ========== Unskipped csp/navigation test and removed duplicate local test BUG=694525 ========== to ========== Unskipped csp/navigation test and removed duplicate local test BUG=694525 Review-Url: https://codereview.chromium.org/2776103003 Cr-Commit-Position: refs/heads/master@{#460342} Committed: https://chromium.googlesource.com/chromium/src/+/1690551c93020ef0ebee1e0a1a52... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/1690551c93020ef0ebee1e0a1a52... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
