Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Unified Diff: third_party/WebKit/Source/core/editing/EphemeralRange.h

Issue 2776103002: Make RenderedRectsForMarkers() to ignore disconnected nodes. (Closed)
Patch Set: upload test file Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/EphemeralRange.h
diff --git a/third_party/WebKit/Source/core/editing/EphemeralRange.h b/third_party/WebKit/Source/core/editing/EphemeralRange.h
index acdbafb3ef6793e8f15208cd919e0af7b5ab583f..c868559d62a167f3156271f1bb3f72d4b3df9962 100644
--- a/third_party/WebKit/Source/core/editing/EphemeralRange.h
+++ b/third_party/WebKit/Source/core/editing/EphemeralRange.h
@@ -105,6 +105,9 @@ class CORE_TEMPLATE_CLASS_EXPORT EphemeralRangeTemplate final {
PositionTemplate<Strategy> startPosition() const;
PositionTemplate<Strategy> endPosition() const;
+ void textRects(Vector<IntRect>&, bool useSelectionHeight = false) const;
Xiaocheng 2017/03/29 19:51:07 This function is just implementation detail and sh
+ IntRect boundingBox() const;
Xiaocheng 2017/03/29 19:51:07 According to the discussion in https://codereview.
+
Node* commonAncestorContainer() const;
// Returns true if |m_startPositoin| == |m_endPosition| or |isNull()|.

Powered by Google App Engine
This is Rietveld 408576698