Make RenderedRectsForMarkers() to ignore disconnected nodes.

third_party/WebKit/Source/core/editing/EphemeralRange.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EphemeralRange_h
 #define EphemeralRange_h
 
 #include "core/editing/Position.h"
 
 namespace blink {
@@ skipping 87 matching lines @@
   EphemeralRangeTemplate<Strategy>& operator=(
       const EphemeralRangeTemplate<Strategy>& other);
 
   bool operator==(const EphemeralRangeTemplate<Strategy>& other) const;
   bool operator!=(const EphemeralRangeTemplate<Strategy>& other) const;
 
   Document& document() const;
   PositionTemplate<Strategy> startPosition() const;
   PositionTemplate<Strategy> endPosition() const;
 
+  void textRects(Vector<IntRect>&, bool useSelectionHeight = false) const;

[Xiaocheng, 2017/03/29 19:51:07]

This function is just implementation detail and shouldn't appear in a header
file. Besides, |userSelectionHeight| is never used.

+  IntRect boundingBox() const;

[Xiaocheng, 2017/03/29 19:51:07]

According to the discussion in https://codereview.chromium.org/2775663008, we
should not make EphemeralRange depend on layout.

Could you introduce new functions in VisibleUnits:

IntRect boundingBox(const EphemeralRange&);
IntRect boundingBox(const EphemeralRangeInFlatTree&);

+
   Node* commonAncestorContainer() const;
 
   // Returns true if |m_startPositoin| == |m_endPosition| or |isNull()|.
   bool isCollapsed() const;
   bool isNull() const {
     DCHECK(isValid());
     return m_startPosition.isNull();
   }
   bool isNotNull() const { return !isNull(); }
 
@@ skipping 23 matching lines @@
 using EphemeralRangeInFlatTree =
     EphemeralRangeTemplate<EditingInFlatTreeStrategy>;
 
 // Returns a newly created |Range| object from |range| or |nullptr| if
 // |range.isNull()| returns true.
 CORE_EXPORT Range* createRange(const EphemeralRange& /* range */);
 
 }  // namespace blink
 
 #endif