Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2776073005:
[turbofan] Use the property access IC trampolines when possible. (Closed)
|
Created:
3 years, 8 months ago by Benedikt Meurer Modified:
3 years, 8 months ago Reviewers:
mvstanton CC:
v8-reviews_googlegroups.com Target Ref:
refs/heads/master Project:
v8 Visibility:
Public. |
Description[turbofan] Use the property access IC trampolines when possible.
Even in optimized code we can utilize the various load and store IC
trampolines to save code space when it's an IC in the outermost
function, as in that case the trampoline can just take the vector
from the parent's frame.
BUG=v8:5267
Review-Url: https://codereview.chromium.org/2776073005
Cr-Commit-Position: refs/heads/master@{#44226}
Committed: https://chromium.googlesource.com/v8/v8/+/98c0f6b1c6825c507fb4a51ff2a8011a9bf78957
Patch Set 1 #Patch Set 2 : Same for the stores. #Patch Set 3 : Fix typo. #Messages
Total messages: 33 (26 generated)
The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
mvstanton@chromium.org changed reviewers: + mvstanton@chromium.org
Cool! LGTM
The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [turbofan] Use the load IC trampolines when possible. Even in optimized code we can utilize the various load IC trampolines to save code space when it's an IC in the outermost function, as in that case the trampoline can just take the vector from the parent's frame. ========== to ========== [turbofan] Use the property access IC trampolines when possible. Even in optimized code we can utilize the various load and store IC trampolines to save code space when it's an IC in the outermost function, as in that case the trampoline can just take the vector from the parent's frame. ==========
Description was changed from ========== [turbofan] Use the property access IC trampolines when possible. Even in optimized code we can utilize the various load and store IC trampolines to save code space when it's an IC in the outermost function, as in that case the trampoline can just take the vector from the parent's frame. ========== to ========== [turbofan] Use the property access IC trampolines when possible. Even in optimized code we can utilize the various load and store IC trampolines to save code space when it's an IC in the outermost function, as in that case the trampoline can just take the vector from the parent's frame. BUG=v8:5267 ==========
The CQ bit was unchecked by bmeurer@chromium.org
The CQ bit was checked by bmeurer@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mvstanton@chromium.org Link to the patchset: https://codereview.chromium.org/2776073005/#ps20001 (title: "Same for the stores.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by bmeurer@chromium.org
Description was changed from ========== [turbofan] Use the property access IC trampolines when possible. Even in optimized code we can utilize the various load and store IC trampolines to save code space when it's an IC in the outermost function, as in that case the trampoline can just take the vector from the parent's frame. BUG=v8:5267 ========== to ========== [turbofan] Use the property access IC trampolines when possible. Even in optimized code we can utilize the various load and store IC trampolines to save code space when it's an IC in the outermost function, as in that case the trampoline can just take the vector from the parent's frame. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel BUG=v8:5267 ==========
The CQ bit was checked by bmeurer@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...) v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)
The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by bmeurer@chromium.org
The CQ bit was checked by bmeurer@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mvstanton@chromium.org Link to the patchset: https://codereview.chromium.org/2776073005/#ps40001 (title: "Fix typo.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [turbofan] Use the property access IC trampolines when possible. Even in optimized code we can utilize the various load and store IC trampolines to save code space when it's an IC in the outermost function, as in that case the trampoline can just take the vector from the parent's frame. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel BUG=v8:5267 ========== to ========== [turbofan] Use the property access IC trampolines when possible. Even in optimized code we can utilize the various load and store IC trampolines to save code space when it's an IC in the outermost function, as in that case the trampoline can just take the vector from the parent's frame. BUG=v8:5267 ==========
The CQ bit was unchecked by bmeurer@chromium.org
The CQ bit was checked by bmeurer@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490788980394200,
"parent_rev": "1c8760c6b5a113478491b99b83d675a8be5ca980", "commit_rev":
"98c0f6b1c6825c507fb4a51ff2a8011a9bf78957"}
Message was sent while issue was closed.
Description was changed from ========== [turbofan] Use the property access IC trampolines when possible. Even in optimized code we can utilize the various load and store IC trampolines to save code space when it's an IC in the outermost function, as in that case the trampoline can just take the vector from the parent's frame. BUG=v8:5267 ========== to ========== [turbofan] Use the property access IC trampolines when possible. Even in optimized code we can utilize the various load and store IC trampolines to save code space when it's an IC in the outermost function, as in that case the trampoline can just take the vector from the parent's frame. BUG=v8:5267 Review-Url: https://codereview.chromium.org/2776073005 Cr-Commit-Position: refs/heads/master@{#44226} Committed: https://chromium.googlesource.com/v8/v8/+/98c0f6b1c6825c507fb4a51ff2a8011a9bf... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/v8/v8/+/98c0f6b1c6825c507fb4a51ff2a8011a9bf... |
