Chromium Code Reviews| Index: chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc |
| diff --git a/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc b/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc |
| index 9465960608042e8f7c87b45e99c3fc4fd1cf7008..2dfbb91b83788aea98bf21a169b4b01994881afb 100644 |
| --- a/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc |
| +++ b/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc |
| @@ -55,13 +55,13 @@ void MetricsRenderFrameObserver::FrameDetached() { |
| void MetricsRenderFrameObserver::DidCommitProvisionalLoad( |
| bool is_new_navigation, |
| - bool is_same_page_navigation) { |
| - // Same-page navigations (e.g. an in-document navigation from a fragment |
| - // link) aren't full page loads, since they don't go to network to load the |
| - // main HTML resource. DidStartProvisionalLoad doesn't get invoked for same |
| - // page navigations, so we may still have an active |
| - // page_timing_metrics_sender_ at this point. |
| - if (is_same_page_navigation) |
| + bool is_same_document_navigation) { |
| + // Same-document navigations (e.g. a navigation from a fragment link) aren't |
| + // full page loads, since they don't go to network to load the main HTML |
| + // resource. DidStartProvisionalLoad doesn't get invoked for same page |
|
nasko
2017/03/27 20:00:21
s/same page/same document/
Eugene But (OOO till 7-30)
2017/03/27 20:41:40
Done.
|
| + // navigations, so we may still have an active page_timing_metrics_sender_ at |
| + // this point. |
| + if (is_same_document_navigation) |
| return; |
| // Make sure to release the sender for a previous navigation, if we have one. |