Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 2775943002: Revert of [ios] Switches ToolbarModelDelegateIOS to use WebStateList. (Closed)

Created:
3 years, 9 months ago by rohitrao (ping after 24h)
Modified:
3 years, 9 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [ios] Switches ToolbarModelDelegateIOS to use WebStateList. (patchset #3 id:40001 of https://codereview.chromium.org/2770223003/ ) Reason for revert: EG tests fail https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.fyi%2FEarlGreyiOS%2F25732%2F%2B%2Frecipes%2Fsteps%2Fios_chrome_ui_egtests__iPhone_6s_iOS_10.0_%2F0%2Flogs%2Fcrash_report__2017-03-24-125038_%2F0 Original issue's description: > [ios] Switches ToolbarModelDelegateIOS to use WebStateList. > > There is one method whose implementation still requires Tab and WebController. > That method has been temporarily implemented using LegacyTabHelper to get the > Tab for a WebState. > > BUG=None > > Review-Url: https://codereview.chromium.org/2770223003 > Cr-Commit-Position: refs/heads/master@{#459504} > Committed: https://chromium.googlesource.com/chromium/src/+/5eb449e1e24522d224cc61be49c0cce7c48d05b3 TBR=sdefresne@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Review-Url: https://codereview.chromium.org/2775943002 Cr-Commit-Position: refs/heads/master@{#459541} Committed: https://chromium.googlesource.com/chromium/src/+/d62591e0a90b1eeb0b967de96c02c9dba3a79a29

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -193 lines) Patch
M ios/chrome/browser/ui/BUILD.gn View 2 chunks +0 lines, -5 lines 0 comments Download
M ios/chrome/browser/ui/browser_view_controller.mm View 1 chunk +1 line, -2 lines 0 comments Download
M ios/chrome/browser/ui/browser_view_controller_unittest.mm View 3 chunks +1 line, -27 lines 0 comments Download
M ios/chrome/browser/ui/omnibox_perftest.mm View 3 chunks +12 lines, -15 lines 0 comments Download
M ios/chrome/browser/ui/toolbar/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/toolbar/toolbar_model_delegate_ios.h View 2 chunks +9 lines, -7 lines 0 comments Download
M ios/chrome/browser/ui/toolbar/toolbar_model_delegate_ios.mm View 3 chunks +14 lines, -10 lines 0 comments Download
M ios/chrome/browser/ui/toolbar/toolbar_model_impl_ios.mm View 2 chunks +20 lines, -31 lines 0 comments Download
M ios/chrome/browser/ui/toolbar/toolbar_model_impl_ios_unittest.mm View 5 chunks +110 lines, -93 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
rohitrao (ping after 24h)
Created Revert of [ios] Switches ToolbarModelDelegateIOS to use WebStateList.
3 years, 9 months ago (2017-03-24 20:42:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2775943002/1
3 years, 9 months ago (2017-03-24 20:43:04 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 20:44:54 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d62591e0a90b1eeb0b967de96c02...

Powered by Google App Engine
This is Rietveld 408576698