PaymentApp: Receive payment app responses in Android

PaymentApp: Receive payment app responses in Android

This change adds a callback parameter to
ServiceWorkerPaymentInstrument.invokePaymentApp, so that the response
from the payment app can be passed back to the merchant.

Depends on https://codereview.chromium.org/2718013004/

BUG=669876
Review-Url: https://codereview.chromium.org/2775933002
Cr-Commit-Position: refs/heads/master@{#460715}
Committed: https://chromium.googlesource.com/chromium/src/+/3e98d5dbbd28482bcb46964bcc5746e463fe5bd2

[tommyt, 2017-03-28 12:38:43]

The CQ bit was checked by tommyt@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 12:39:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommyt, 2017-03-28 13:45:29]

tommyt@opera.com changed reviewers:
+ dtrainor@chromium.org, rouslan@chromium.org

[tommyt, 2017-03-28 13:45:30]

I've added dtrainor@ to review
chrome/browser/android/payments/service_worker_payment_app_bridge.cc, and
rouslan@ to review the other two files.

PTAL :)

[please use gerrit instead, 2017-03-28 13:52:56]

LGTM % nit

https://codereview.chromium.org/2775933002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentAppBridge.java
(right):

https://codereview.chromium.org/2775933002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentAppBridge.java:183:
PaymentDetailsModifier[] modifiers, Object callback);
You should be able to use PaymentInstrument.InstrumentDetailsCallback instead of
Object here and in onPaymentAppInvoked().

[tommyt, 2017-03-28 14:04:48]

https://codereview.chromium.org/2775933002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentAppBridge.java
(right):

https://codereview.chromium.org/2775933002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentAppBridge.java:183:
PaymentDetailsModifier[] modifiers, Object callback);
On 2017/03/28 13:52:56, ಠ_ಠ wrote:
> You should be able to use PaymentInstrument.InstrumentDetailsCallback instead
of
> Object here and in onPaymentAppInvoked().

This is actually the same problem as I discussed with Bernard Bauer here:
https://codereview.chromium.org/2586213002/diff/100001/chrome/android/java/sr...

He suggested to add a todo referencing bug 505554 which resulted in the TODO
comment a few lines up. I can add the same TODO for this function too, if you
like?

[please use gerrit instead, 2017-03-28 14:06:51]

On 2017/03/28 14:04:48, tommyt wrote:
>
https://codereview.chromium.org/2775933002/diff/20001/chrome/android/java/src...
> File
>
chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentAppBridge.java
> (right):
> 
>
https://codereview.chromium.org/2775933002/diff/20001/chrome/android/java/src...
>
chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentAppBridge.java:183:
> PaymentDetailsModifier[] modifiers, Object callback);
> On 2017/03/28 13:52:56, ಠ_ಠ wrote:
> > You should be able to use PaymentInstrument.InstrumentDetailsCallback
instead
> of
> > Object here and in onPaymentAppInvoked().
> 
> This is actually the same problem as I discussed with Bernard Bauer here:
>
https://codereview.chromium.org/2586213002/diff/100001/chrome/android/java/sr...
> 
> He suggested to add a todo referencing bug 505554 which resulted in the TODO
> comment a few lines up. I can add the same TODO for this function too, if you
> like?

Sounds good.

[tommyt, 2017-03-28 14:12:12]

The CQ bit was checked by tommyt@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 14:12:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommyt, 2017-03-28 14:13:03]

On 2017/03/28 14:06:51, ಠ_ಠ wrote:
> On 2017/03/28 14:04:48, tommyt wrote:
> >
>
https://codereview.chromium.org/2775933002/diff/20001/chrome/android/java/src...
> > File
> >
>
chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentAppBridge.java
> > (right):
> > 
> >
>
https://codereview.chromium.org/2775933002/diff/20001/chrome/android/java/src...
> >
>
chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentAppBridge.java:183:
> > PaymentDetailsModifier[] modifiers, Object callback);
> > On 2017/03/28 13:52:56, ಠ_ಠ wrote:
> > > You should be able to use PaymentInstrument.InstrumentDetailsCallback
> instead
> > of
> > > Object here and in onPaymentAppInvoked().
> > 
> > This is actually the same problem as I discussed with Bernard Bauer here:
> >
>
https://codereview.chromium.org/2586213002/diff/100001/chrome/android/java/sr...
> > 
> > He suggested to add a todo referencing bug 505554 which resulted in the TODO
> > comment a few lines up. I can add the same TODO for this function too, if
you
> > like?
> 
> Sounds good.

Done

[please use gerrit instead, 2017-03-28 14:17:28]

still lgtm

[commit-bot: I haz the power, 2017-03-28 16:00:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 16:00:37]

Dry run: This issue passed the CQ dry run.

[David Trainor- moved to gerrit, 2017-03-28 23:51:18]

lgtm

[tommyt, 2017-03-30 09:40:24]

The CQ bit was checked by tommyt@opera.com

[commit-bot: I haz the power, 2017-03-30 09:40:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 10:18:56]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490866824031410,
"parent_rev": "843a95b06e362f496929c6edc0b700f150180a97", "commit_rev":
"3e98d5dbbd28482bcb46964bcc5746e463fe5bd2"}

[commit-bot: I haz the power, 2017-03-30 10:19:44]

Description was changed from

==========
PaymentApp: Receive payment app responses in Android

This change adds a callback parameter to
ServiceWorkerPaymentInstrument.invokePaymentApp, so that the response
from the payment app can be passed back to the merchant.

Depends on https://codereview.chromium.org/2718013004/

BUG=669876
==========

to

==========
PaymentApp: Receive payment app responses in Android

This change adds a callback parameter to
ServiceWorkerPaymentInstrument.invokePaymentApp, so that the response
from the payment app can be passed back to the merchant.

Depends on https://codereview.chromium.org/2718013004/

BUG=669876

Review-Url: https://codereview.chromium.org/2775933002
Cr-Commit-Position: refs/heads/master@{#460715}
Committed:
https://chromium.googlesource.com/chromium/src/+/3e98d5dbbd28482bcb46964bcc57...
==========

[commit-bot: I haz the power, 2017-03-30 10:19:45]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3e98d5dbbd28482bcb46964bcc57...

[DJJAAM.COM, 2017-08-12 19:12:28]

https://psiphon.me/

[williamjack12344, 2017-09-23 10:16:15]

If the application is working, you will be notified of the application and it
will say “VPN is activated by Psiphon’ along with “Psiphon3 is running in whole
device mode’ after this.
<a href="http://www.psiphon3download.com/">Psiphon</a>

[williamjack12344, 2017-09-23 10:16:54]

On 2017/09/23 10:16:15, williamjack12344 wrote:
> If the application is working, you will be notified of the application and it
> will say “VPN is activated by Psiphon’ along with “Psiphon3 is running in
whole
> device mode’ after this.
> [url="http://www.psiphon3download.com/"]Psiphon[/url]