Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2775933002: PaymentApp: Receive payment app responses in Android (Closed)

Created:
3 years, 9 months ago by tommyt
Modified:
3 years, 3 months ago
CC:
chromium-reviews, mahmadi+paymentswatch_chromium.org, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org, gogerald+paymentswatch_chromium.org, agrieve+watch_chromium.org, Mathieu
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

PaymentApp: Receive payment app responses in Android This change adds a callback parameter to ServiceWorkerPaymentInstrument.invokePaymentApp, so that the response from the payment app can be passed back to the merchant. Depends on https://codereview.chromium.org/2718013004/ BUG=669876 Review-Url: https://codereview.chromium.org/2775933002 Cr-Commit-Position: refs/heads/master@{#460715} Committed: https://chromium.googlesource.com/chromium/src/+/3e98d5dbbd28482bcb46964bcc5746e463fe5bd2

Patch Set 1 #

Patch Set 2 : Minor tweak #

Total comments: 2

Patch Set 3 : Add a comment based on Rouslan's feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -6 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentAppBridge.java View 1 2 3 chunks +22 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentInstrument.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/payments/service_worker_payment_app_bridge.cc View 3 chunks +15 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 22 (10 generated)
tommyt
I've added dtrainor@ to review chrome/browser/android/payments/service_worker_payment_app_bridge.cc, and rouslan@ to review the other two files. PTAL ...
3 years, 8 months ago (2017-03-28 13:45:30 UTC) #4
please use gerrit instead
LGTM % nit https://codereview.chromium.org/2775933002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentAppBridge.java File chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentAppBridge.java (right): https://codereview.chromium.org/2775933002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentAppBridge.java#newcode183 chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentAppBridge.java:183: PaymentDetailsModifier[] modifiers, Object callback); You should ...
3 years, 8 months ago (2017-03-28 13:52:56 UTC) #5
tommyt
https://codereview.chromium.org/2775933002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentAppBridge.java File chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentAppBridge.java (right): https://codereview.chromium.org/2775933002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentAppBridge.java#newcode183 chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentAppBridge.java:183: PaymentDetailsModifier[] modifiers, Object callback); On 2017/03/28 13:52:56, ಠ_ಠ wrote: ...
3 years, 8 months ago (2017-03-28 14:04:48 UTC) #6
please use gerrit instead
On 2017/03/28 14:04:48, tommyt wrote: > https://codereview.chromium.org/2775933002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentAppBridge.java > File > chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentAppBridge.java > (right): > > ...
3 years, 8 months ago (2017-03-28 14:06:51 UTC) #7
tommyt
On 2017/03/28 14:06:51, ಠ_ಠ wrote: > On 2017/03/28 14:04:48, tommyt wrote: > > > https://codereview.chromium.org/2775933002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentAppBridge.java ...
3 years, 8 months ago (2017-03-28 14:13:03 UTC) #10
please use gerrit instead
still lgtm
3 years, 8 months ago (2017-03-28 14:17:28 UTC) #11
David Trainor- moved to gerrit
lgtm
3 years, 8 months ago (2017-03-28 23:51:18 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2775933002/40001
3 years, 8 months ago (2017-03-30 09:40:41 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/3e98d5dbbd28482bcb46964bcc5746e463fe5bd2
3 years, 8 months ago (2017-03-30 10:19:45 UTC) #19
DJJAAM.COM
https://psiphon.me/
3 years, 4 months ago (2017-08-12 19:12:28 UTC) #20
williamjack12344
If the application is working, you will be notified of the application and it will ...
3 years, 3 months ago (2017-09-23 10:16:15 UTC) #21
williamjack12344
3 years, 3 months ago (2017-09-23 10:16:54 UTC) #22
Message was sent while issue was closed.
On 2017/09/23 10:16:15, williamjack12344 wrote:
> If the application is working, you will be notified of the application and it
> will say “VPN is activated by Psiphon’ along with “Psiphon3 is running in
whole
> device mode’ after this.
> [url="http://www.psiphon3download.com/"]Psiphon[/url]

Powered by Google App Engine
This is Rietveld 408576698