Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Issue 2775923002: Add origins to the Background Fetch Mojo calls. (Closed)

Created:
3 years, 9 months ago by Peter Beverloo
Modified:
3 years, 9 months ago
Reviewers:
Tom Sepez, shimazu, dcheng
CC:
chromium-reviews, awdf+watch_chromium.org, Aaron Boodman, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, blink-reviews, dglazkov+blink, darin-cc_chromium.org, haraken, darin (slow to review), harkness+watch_chromium.org, blink-reviews-api_chromium.org, qsr+mojo_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add origins to the Background Fetch Mojo calls. Modulo the Request mojofication (CL 2762303002), this concludes the Mojo interfaces necessary for Background Fetch. BUG=692535, 692534 Review-Url: https://codereview.chromium.org/2775923002 Cr-Commit-Position: refs/heads/master@{#459600} Committed: https://chromium.googlesource.com/chromium/src/+/ad305c85c6689084129632ec990fb17e16311afe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -8 lines) Patch
M content/browser/background_fetch/background_fetch_service_impl.h View 2 chunks +9 lines, -0 lines 0 comments Download
M content/browser/background_fetch/background_fetch_service_impl.cc View 6 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/background_fetch/BackgroundFetchBridge.h View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/background_fetch/BackgroundFetchBridge.cpp View 5 chunks +12 lines, -4 lines 0 comments Download
M third_party/WebKit/public/platform/modules/background_fetch/background_fetch.mojom View 3 chunks +14 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (9 generated)
Peter Beverloo
+tsepez
3 years, 9 months ago (2017-03-24 19:43:51 UTC) #2
Tom Sepez
refresh my memory: which process is specifying the origin information, and why can we trust ...
3 years, 9 months ago (2017-03-24 20:17:07 UTC) #5
Peter Beverloo
On 2017/03/24 20:17:07, Tom Sepez wrote: > refresh my memory: which process is specifying the ...
3 years, 9 months ago (2017-03-24 20:41:11 UTC) #6
Tom Sepez
lgtm
3 years, 9 months ago (2017-03-24 21:19:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2775923002/1
3 years, 9 months ago (2017-03-24 23:35:57 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/ad305c85c6689084129632ec990fb17e16311afe
3 years, 9 months ago (2017-03-24 23:43:15 UTC) #14
dcheng
On 2017/03/24 23:43:15, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
3 years, 9 months ago (2017-03-24 23:57:00 UTC) #15
Peter Beverloo
3 years, 9 months ago (2017-03-25 00:03:58 UTC) #17
Message was sent while issue was closed.
+shimazu who will be able to comment better than I can

Powered by Google App Engine
This is Rietveld 408576698