Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2775893003: Removed dead code from NavigationManagerImpl::GetIndexForOffset. (Closed)

Created:
3 years, 9 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 8 months ago
Reviewers:
kkhorimoto
CC:
chromium-reviews, Eugene But (OOO till 7-30), ios-reviews+web_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed dead code from NavigationManagerImpl::GetIndexForOffset. If pending item exists and pending index == -1, then last committed item is always the last one and forward navigation is not possible anyway. BUG=661858 Review-Url: https://codereview.chromium.org/2775893003 Cr-Commit-Position: refs/heads/master@{#460559} Committed: https://chromium.googlesource.com/chromium/src/+/4e7d0d74049c9a5fc567355ea59510a323b2538a

Patch Set 1 : Run tests with DCHECK #

Patch Set 2 : Run tests with DCHECK 2 #

Patch Set 3 : Actually removed dead code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -31 lines) Patch
M ios/web/navigation/crw_session_controller.mm View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ios/web/navigation/navigation_manager_impl.mm View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
M ios/web/navigation/navigation_manager_impl_unittest.mm View 1 2 1 chunk +0 lines, -21 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Eugene But (OOO till 7-30)
3 years, 8 months ago (2017-03-27 17:24:45 UTC) #3
kkhorimoto
lgtm
3 years, 8 months ago (2017-03-29 00:41:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2775893003/40001
3 years, 8 months ago (2017-03-29 21:03:50 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 22:49:04 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/4e7d0d74049c9a5fc567355ea595...

Powered by Google App Engine
This is Rietveld 408576698