Fix decode-audio-data-basic.html to test decoding on close context

Fix decode-audio-data-basic.html to test decoding on close context

The last task of the test has some inconsistency between the description
and the testing code. This CL fixes this mismatch by:
 - Using online context for all the decoding.
 - Fixing the label of the last task.

BUG=692650
TEST=
LayoutTests/webaudio/decodeAudioData/decode-audio-data-basic.html

Review-Url: https://codereview.chromium.org/2775853002
Cr-Commit-Position: refs/heads/master@{#459561}
Committed: https://chromium.googlesource.com/chromium/src/+/9927414f3150565bbe283e1134a2cfb966a60b5e

[hongchan, 2017-03-24 16:51:13]

Patchset #1 (id:1) has been deleted

[hongchan, 2017-03-24 16:52:18]

hongchan@chromium.org changed reviewers:
+ rtoy@chromium.org

[hongchan, 2017-03-24 16:52:19]

PTAL.

https://codereview.chromium.org/2775853002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/decodeAudioData/decode-audio-data-basic.html
(right):

https://codereview.chromium.org/2775853002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/decodeAudioData/decode-audio-data-basic.html:118:
successOrErrorCallback);
Let me know if this change bothers you too much. I simply wrapped them at 80.

[Raymond Toy, 2017-03-24 17:07:46]

lgtm with nit.

https://codereview.chromium.org/2775853002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/decodeAudioData/decode-audio-data-basic.html
(right):

https://codereview.chromium.org/2775853002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/decodeAudioData/decode-audio-data-basic.html:12:
// state of AudioContext. So we use the online context in this test.
Add comment that any resampling of the test file is ok for this test.

[hongchan, 2017-03-24 19:00:26]

The CQ bit was checked by hongchan@chromium.org

[hongchan, 2017-03-24 19:00:26]

The patchset sent to the CQ was uploaded after l-g-t-m from rtoy@chromium.org
Link to the patchset: https://codereview.chromium.org/2775853002/#ps40001
(title: "Add more comment.")

[hongchan, 2017-03-24 19:00:36]

https://codereview.chromium.org/2775853002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/decodeAudioData/decode-audio-data-basic.html
(right):

https://codereview.chromium.org/2775853002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/decodeAudioData/decode-audio-data-basic.html:12:
// state of AudioContext. So we use the online context in this test.
On 2017/03/24 17:07:46, Raymond Toy wrote:
> Add comment that any resampling of the test file is ok for this test.

Done.

[commit-bot: I haz the power, 2017-03-24 19:01:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 21:37:34]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490382026380550,
"parent_rev": "161a32635f89a1f6bfde9e8f5836d747529a0d56", "commit_rev":
"9927414f3150565bbe283e1134a2cfb966a60b5e"}

[commit-bot: I haz the power, 2017-03-24 21:39:26]

Description was changed from

==========
Fix decode-audio-data-basic.html to test decoding on close context

The last task of the test has some inconsistency between the description
and the testing code. This CL fixes this mismatch by:
 - Using online context for all the decoding.
 - Fixing the label of the last task.

BUG=692650
TEST=
LayoutTests/webaudio/decodeAudioData/decode-audio-data-basic.html
==========

to

==========
Fix decode-audio-data-basic.html to test decoding on close context

The last task of the test has some inconsistency between the description
and the testing code. This CL fixes this mismatch by:
 - Using online context for all the decoding.
 - Fixing the label of the last task.

BUG=692650
TEST=
LayoutTests/webaudio/decodeAudioData/decode-audio-data-basic.html

Review-Url: https://codereview.chromium.org/2775853002
Cr-Commit-Position: refs/heads/master@{#459561}
Committed:
https://chromium.googlesource.com/chromium/src/+/9927414f3150565bbe283e1134a2...
==========

[commit-bot: I haz the power, 2017-03-24 21:39:27]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9927414f3150565bbe283e1134a2...