Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 2775793002: [devil] Use AdbWrapper.GetAdbPath in devil.android.forwarder (Closed)

Created:
3 years, 9 months ago by jbudorick
Modified:
3 years, 9 months ago
Reviewers:
perezju
CC:
catapult-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[devil] Use AdbWrapper.GetAdbPath in devil.android.forwarder Previously, the forwarder was going directly to devil_env.config for the adb path. That doesn't line up with AdbWrapper's behavior when the adb in use is coming out of a locally configured SDK. This patch makes the forwarder defer to AdbWrapper for adb path determination. BUG=chromium:703774 Review-Url: https://codereview.chromium.org/2775793002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/92933c1240e7498c6aa782a8160297f1e738f31b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M devil/devil/android/forwarder.py View 4 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
jbudorick
3 years, 9 months ago (2017-03-24 13:16:28 UTC) #2
perezju
lgtm, thanks!
3 years, 9 months ago (2017-03-24 13:40:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2775793002/1
3 years, 9 months ago (2017-03-24 13:46:39 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 14:08:50 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698