Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2775773003:
[Desktop FRE] Do not show Welcome page to profiles created in M56 or M57 (Closed)
DescriptionDo not show Welcome page to profiles created in M56 or M57
BUG=704977
Review-Url: https://codereview.chromium.org/2775773003
Cr-Commit-Position: refs/heads/master@{#460533}
Committed: https://chromium.googlesource.com/chromium/src/+/5e6e32305efbc1d65377d8ee878d3f775a2c8366
Patch Set 1 #Patch Set 2 : static #Patch Set 3 : Working locally #Patch Set 4 : windows includes #Patch Set 5 : Update version #Patch Set 6 : rebase #
Total comments: 2
Patch Set 7 : remove pref null check #
Messages
Total messages: 45 (38 generated)
The CQ bit was checked by tmartino@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
The CQ bit was checked by tmartino@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by tmartino@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...) win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by tmartino@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Fix profile welcome problem BUG= ========== to ========== Do not show Welcome page to profiles created in M56 BUG=704977 ==========
Description was changed from ========== Do not show Welcome page to profiles created in M56 BUG=704977 ========== to ========== Do not show Welcome page to profiles created in M56 or M57 BUG=704977 ==========
The CQ bit was checked by tmartino@chromium.org to run a CQ dry run
The CQ bit was checked by tmartino@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by tmartino@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
tmartino@chromium.org changed reviewers: + anthonyvd@chromium.org
+anthonyvd for OWNERS on profile_manager.cc
profile_manager.cc lgtm
tmartino@chromium.org changed reviewers: + pkasting@chromium.org
+pkasting for OWNERS on c/b/ui
LGTM https://codereview.chromium.org/2775773003/diff/100001/chrome/browser/ui/star... File chrome/browser/ui/startup/startup_browser_creator_impl.cc (right): https://codereview.chromium.org/2775773003/diff/100001/chrome/browser/ui/star... chrome/browser/ui/startup/startup_browser_creator_impl.cc:293: if (pref) Can this conditional ever fail? I don't know why we need this null-check.
The CQ bit was checked by tmartino@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2775773003/diff/100001/chrome/browser/ui/star... File chrome/browser/ui/startup/startup_browser_creator_impl.cc (right): https://codereview.chromium.org/2775773003/diff/100001/chrome/browser/ui/star... chrome/browser/ui/startup/startup_browser_creator_impl.cc:293: if (pref) On 2017/03/28 at 21:42:43, Peter Kasting wrote: > Can this conditional ever fail? I don't know why we need this null-check. I was taking a conservative approach, since GetPrefs is a virtual that technically could do all kinds of things. There seem to be lots of instances of using this without a null-check, though, so it seems safe to remove. Done here, and will update my other outstanding CL accordingly.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by tmartino@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from pkasting@chromium.org, anthonyvd@chromium.org Link to the patchset: https://codereview.chromium.org/2775773003/#ps120001 (title: "remove pref null check")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 120001, "attempt_start_ts": 1490820301492780,
"parent_rev": "c64c69fce0b29af200419ab2f9df75e3d8e693d5", "commit_rev":
"76308ba28327eee0f5cbb7c68e1c9fae99433a18"}
CQ is committing da patch.
Bot data: {"patchset_id": 120001, "attempt_start_ts": 1490820301492780,
"parent_rev": "1b248cbbf1eeee85a85e1d12b4d1d860e6755fa4", "commit_rev":
"5e6e32305efbc1d65377d8ee878d3f775a2c8366"}
Message was sent while issue was closed.
Description was changed from ========== Do not show Welcome page to profiles created in M56 or M57 BUG=704977 ========== to ========== Do not show Welcome page to profiles created in M56 or M57 BUG=704977 Review-Url: https://codereview.chromium.org/2775773003 Cr-Commit-Position: refs/heads/master@{#460533} Committed: https://chromium.googlesource.com/chromium/src/+/5e6e32305efbc1d65377d8ee878d... ==========
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as https://chromium.googlesource.com/chromium/src/+/5e6e32305efbc1d65377d8ee878d... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
