Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 2775733002: DevTools: minor cleanup for the icons (Closed)

Created:
3 years, 9 months ago by lushnikov
Modified:
3 years, 9 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: minor cleanup for the icons This is a minor cleanup for the icons before re-arranging a spritesheets by their sizes. This patch: - kills unused icon from toolbarButtonGlyphs.svg - kills smallicon-clear-input since its a dupe of smallicon-gray-cross-hover - kills largeicon-block since it is a left-over after the icon removal - fixes size of largeicon-chevron to be 28x24 BUG=700249 R=dgozman Review-Url: https://codereview.chromium.org/2775733002 Cr-Commit-Position: refs/heads/master@{#459461} Committed: https://chromium.googlesource.com/chromium/src/+/0b9720c2eb9ba96fb1ca3a22a721ae0bd0b6a25a

Patch Set 1 #

Total comments: 2

Messages

Total messages: 12 (7 generated)
lushnikov
please, take a look
3 years, 9 months ago (2017-03-24 00:27:27 UTC) #1
dgozman
lgtm https://codereview.chromium.org/2775733002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/Icon.js File third_party/WebKit/Source/devtools/front_end/ui/Icon.js (right): https://codereview.chromium.org/2775733002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/Icon.js#newcode189 third_party/WebKit/Source/devtools/front_end/ui/Icon.js:189: 'largeicon-chevron': {x: -68, y: -143, width: 28, height: ...
3 years, 9 months ago (2017-03-24 16:53:59 UTC) #6
lushnikov
https://codereview.chromium.org/2775733002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/Icon.js File third_party/WebKit/Source/devtools/front_end/ui/Icon.js (right): https://codereview.chromium.org/2775733002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/Icon.js#newcode189 third_party/WebKit/Source/devtools/front_end/ui/Icon.js:189: 'largeicon-chevron': {x: -68, y: -143, width: 28, height: 24, ...
3 years, 9 months ago (2017-03-24 16:55:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2775733002/1
3 years, 9 months ago (2017-03-24 16:56:03 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 17:03:33 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0b9720c2eb9ba96fb1ca3a22a721...

Powered by Google App Engine
This is Rietveld 408576698