Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 2775723002: Enable RGBA_4444 in GpuRasterBufferProvider (Closed)

Created:
3 years, 9 months ago by ericrk
Modified:
3 years, 9 months ago
Reviewers:
ccameron
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable RGBA_4444 in GpuRasterBufferProvider Currently, OneCopy/ZeroCopyRasterBufferProvider supports RGBA_4444 (used in Svelte). This change adds similar logic to GpuRasterBufferProvider. This also splits ResourceProvider::IsResourceFormatSupported into ResourceProvider::IsTextureFormatSupported and IsRasterBufferFormatSupported. This naming matches the existing best_texture_format() and best_raster_buffer_format() names. BUG=704680 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2775723002 Cr-Commit-Position: refs/heads/master@{#459494} Committed: https://chromium.googlesource.com/chromium/src/+/d03c005d730e9510dd6afa7f8d8199e370db96f5

Patch Set 1 #

Patch Set 2 : tweaks #

Total comments: 4

Patch Set 3 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -10 lines) Patch
M cc/output/gl_renderer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/raster/gpu_raster_buffer_provider.h View 2 chunks +2 lines, -0 lines 0 comments Download
M cc/raster/gpu_raster_buffer_provider.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M cc/raster/one_copy_raster_buffer_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/raster/raster_buffer_provider_perftest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/raster/raster_buffer_provider_unittest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M cc/raster/zero_copy_raster_buffer_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/resource_provider.h View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M cc/resources/resource_provider.cc View 1 2 chunks +29 lines, -1 line 0 comments Download
M cc/test/layer_tree_pixel_resource_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 18 (10 generated)
ericrk
3 years, 9 months ago (2017-03-23 21:09:32 UTC) #3
ccameron
I'd prefer to hoist up some of this near-copy-paste functionality into RasterBufferProvider base class, but ...
3 years, 9 months ago (2017-03-23 22:20:14 UTC) #6
ccameron
On 2017/03/23 22:20:14, ccameron wrote: > I'd prefer to hoist up some of this near-copy-paste ...
3 years, 9 months ago (2017-03-23 22:20:43 UTC) #7
ericrk
https://codereview.chromium.org/2775723002/diff/20001/cc/raster/gpu_raster_buffer_provider.cc File cc/raster/gpu_raster_buffer_provider.cc (right): https://codereview.chromium.org/2775723002/diff/20001/cc/raster/gpu_raster_buffer_provider.cc#newcode179 cc/raster/gpu_raster_buffer_provider.cc:179: bool must_support_alpha) const { On 2017/03/23 22:20:14, ccameron wrote: ...
3 years, 9 months ago (2017-03-24 01:46:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2775723002/40001
3 years, 9 months ago (2017-03-24 01:46:59 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/335095)
3 years, 9 months ago (2017-03-24 03:35:33 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2775723002/40001
3 years, 9 months ago (2017-03-24 17:35:50 UTC) #15
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 18:49:47 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/d03c005d730e9510dd6afa7f8d81...

Powered by Google App Engine
This is Rietveld 408576698