Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(884)

Issue 2775713002: Optimize the speed of array iteration in Audit (Closed)

Created:
3 years, 9 months ago by hongchan
Modified:
3 years, 9 months ago
Reviewers:
Raymond Toy
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Optimize the speed of array iteration in Audit Some array iterations in Audit are using the new for(..in..) syntax, which is much slower than the regular for () loop. This CL replaces all instances of for(..in..) against array with for(). BUG=704652 Review-Url: https://codereview.chromium.org/2775713002 Cr-Commit-Position: refs/heads/master@{#459423} Committed: https://chromium.googlesource.com/chromium/src/+/fad633b5888c53d2cf46b6c4ec2eb7d196f7ad3f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -23 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/resources/audit.js View 8 chunks +34 lines, -23 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
hongchan
PTAL.
3 years, 9 months ago (2017-03-23 23:48:12 UTC) #6
Raymond Toy
lgtm
3 years, 9 months ago (2017-03-24 14:53:19 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2775713002/40001
3 years, 9 months ago (2017-03-24 14:54:02 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 14:59:12 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/fad633b5888c53d2cf46b6c4ec2e...

Powered by Google App Engine
This is Rietveld 408576698