Fix missing HEADLESS_EXPORT defines

Fix missing HEADLESS_EXPORT defines

BUG=686608
Review-Url: https://codereview.chromium.org/2775693003
Cr-Commit-Position: refs/heads/master@{#459694}
Committed: https://chromium.googlesource.com/chromium/src/+/edb2d15c8a542b5e7ee88fd49a055b4a8d62ff56

[dvallet, 2017-03-24 00:48:59]

The CQ bit was checked by dvallet@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 00:49:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 01:24:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 01:24:59]

Dry run: This issue passed the CQ dry run.

[dvallet, 2017-03-24 01:57:01]

dvallet@chromium.org changed reviewers:
+ skyostil@chromium.org

[dvallet, 2017-03-24 01:57:02]

I've been researching a bit how to do this properly for Windows. 
This is what is needed to get to compile for dependencies that are pulled by
headless_unittests, headless_browsetests, headless_shell, and headless_example

[dvallet, 2017-03-24 01:59:17]

Description was changed from

==========
Fix missing HEADLESS_EXPORT defines
==========

to

==========
Fix missing HEADLESS_EXPORT defines

BUG=686608
==========

[Sami, 2017-03-24 10:28:40]

lgtm with a tweak, thanks!

https://codereview.chromium.org/2775693003/diff/20001/headless/lib/browser/he...
File headless/lib/browser/headless_browser_impl.h (right):

https://codereview.chromium.org/2775693003/diff/20001/headless/lib/browser/he...
headless/lib/browser/headless_browser_impl.h:36: class HEADLESS_EXPORT
HeadlessBrowserImpl : public HeadlessBrowser {
Are you sure this one is needed? The impl class shouldn't be used by anyone
outside the library directly. Which target fails to link without this?

Edit: looks like these are for some of the tests, right? Could you add a comment
like "// Exported for tests." to make that clear?

https://codereview.chromium.org/2775693003/diff/20001/headless/lib/browser/he...
File headless/lib/browser/headless_web_contents_impl.h (right):

https://codereview.chromium.org/2775693003/diff/20001/headless/lib/browser/he...
headless/lib/browser/headless_web_contents_impl.h:32: class HEADLESS_EXPORT
HeadlessWebContentsImpl
Ditto.

https://codereview.chromium.org/2775693003/diff/20001/headless/lib/headless_c...
File headless/lib/headless_content_main_delegate.h (right):

https://codereview.chromium.org/2775693003/diff/20001/headless/lib/headless_c...
headless/lib/headless_content_main_delegate.h:27: class HEADLESS_EXPORT
HeadlessContentMainDelegate
Ditto.

[dvallet, 2017-03-27 02:44:02]

https://codereview.chromium.org/2775693003/diff/20001/headless/lib/browser/he...
File headless/lib/browser/headless_browser_impl.h (right):

https://codereview.chromium.org/2775693003/diff/20001/headless/lib/browser/he...
headless/lib/browser/headless_browser_impl.h:36: class HEADLESS_EXPORT
HeadlessBrowserImpl : public HeadlessBrowser {
On 2017/03/24 at 10:28:40, Sami wrote:
> Are you sure this one is needed? The impl class shouldn't be used by anyone
outside the library directly. Which target fails to link without this?
> 
> Edit: looks like these are for some of the tests, right? Could you add a
comment like "// Exported for tests." to make that clear?

Done

https://codereview.chromium.org/2775693003/diff/20001/headless/lib/browser/he...
File headless/lib/browser/headless_web_contents_impl.h (right):

https://codereview.chromium.org/2775693003/diff/20001/headless/lib/browser/he...
headless/lib/browser/headless_web_contents_impl.h:32: class HEADLESS_EXPORT
HeadlessWebContentsImpl
On 2017/03/24 10:28:40, Sami wrote:
> Ditto.

Done.

https://codereview.chromium.org/2775693003/diff/20001/headless/lib/headless_c...
File headless/lib/headless_content_main_delegate.h (right):

https://codereview.chromium.org/2775693003/diff/20001/headless/lib/headless_c...
headless/lib/headless_content_main_delegate.h:27: class HEADLESS_EXPORT
HeadlessContentMainDelegate
On 2017/03/24 10:28:40, Sami wrote:
> Ditto.

Done.

[dvallet, 2017-03-27 02:44:09]

The CQ bit was checked by dvallet@chromium.org

[dvallet, 2017-03-27 02:44:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
skyostil@chromium.org
Link to the patchset: https://codereview.chromium.org/2775693003/#ps60001
(title: "Added extra headless_export")

[commit-bot: I haz the power, 2017-03-27 02:44:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 03:10:37]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490582649448880,
"parent_rev": "ffd2047874749f81c94c04d969361ec0316f05d9", "commit_rev":
"edb2d15c8a542b5e7ee88fd49a055b4a8d62ff56"}

[commit-bot: I haz the power, 2017-03-27 03:12:11]

Description was changed from

==========
Fix missing HEADLESS_EXPORT defines

BUG=686608
==========

to

==========
Fix missing HEADLESS_EXPORT defines

BUG=686608

Review-Url: https://codereview.chromium.org/2775693003
Cr-Commit-Position: refs/heads/master@{#459694}
Committed:
https://chromium.googlesource.com/chromium/src/+/edb2d15c8a542b5e7ee88fd49a05...
==========

[commit-bot: I haz the power, 2017-03-27 03:12:12]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/edb2d15c8a542b5e7ee88fd49a05...