LayoutObject::absoluteBoundingBoxRectForRange() should take EphemeralRange

third_party/WebKit/Source/core/layout/LayoutObject.h

Index: third_party/WebKit/Source/core/layout/LayoutObject.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutObject.h b/third_party/WebKit/Source/core/layout/LayoutObject.h
index 79b65ea12f6661095f937a0e57d6fd3205c35ddc..f83ed5a99730086833a2ab886ff385f8dca89289 100644
--- a/third_party/WebKit/Source/core/layout/LayoutObject.h
+++ b/third_party/WebKit/Source/core/layout/LayoutObject.h
@@ -30,6 +30,7 @@
 #include "core/CoreExport.h"
 #include "core/dom/Document.h"
 #include "core/dom/DocumentLifecycle.h"
+#include "core/editing/EphemeralRange.h"

[yoichio, 2017/03/29 01:51:15]

Could you declare |class EphemeralRange;| instead of inclusion?

[Xiaocheng, 2017/03/29 02:16:03]

|EphemeralRange| is just a alias, which cannot be forward declared.

In fact, this bothers me a little because now a lot of headers have to include
the full EphemeralRange.h instead of a forward declaration, which increases
compiling time.

Maybe we should split EphemeralRange.h into two headers:

EphemeralRangeFwd.h:

template <typename Strategy> class EphemeralRangeTemplate;
using EphemeralRange = EphemeralRangeTemplate<EditingStrategy>;
using EphemeralRangeInFlatTree =
EphemeralRangeTemplate<EditingInFlatTreeStrategy>;

EphemeralRange.h:

#include "EphemeralRangeFwd.h"

template <typename Strategy>
class EphemeralRange {
  // Full class declaration
};

Then we can include EphemeralRangeFwd.h in other header files, and
EphemeralRange.h in .cpp files.

Or maybe we can have an "EditingForward.h" collecting all such forward template
class and alias declarations.

 #include "core/editing/PositionWithAffinity.h"
 #include "core/layout/LayoutObjectChildList.h"
 #include "core/layout/MapCoordinatesFlags.h"
@@ -1281,7 +1282,7 @@ class CORE_EXPORT LayoutObject : public ImageResourceObserver,
   virtual void absoluteQuads(Vector<FloatQuad>&,
                              MapCoordinatesFlags mode = 0) const {}
 
-  static FloatRect absoluteBoundingBoxRectForRange(const Range*);
+  static FloatRect absoluteBoundingBoxRectForRange(const EphemeralRange&);
 
   // The bounding box (see: absoluteBoundingBoxRect) including all descendant
   // bounding boxes.