LayoutObject::absoluteBoundingBoxRectForRange() should take EphemeralRange

third_party/WebKit/Source/core/layout/LayoutObject.h

 /*
  * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
  *           (C) 2000 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Dirk Mueller (mueller@kde.org)
  *           (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc.
  *               All rights reserved.
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
@@ skipping 12 matching lines @@
  * Boston, MA 02110-1301, USA.
  *
  */
 
 #ifndef LayoutObject_h
 #define LayoutObject_h
 
 #include "core/CoreExport.h"
 #include "core/dom/Document.h"
 #include "core/dom/DocumentLifecycle.h"
+#include "core/editing/EphemeralRange.h"

[yoichio, 2017/03/29 01:51:15]

Could you declare |class EphemeralRange;| instead of inclusion?

[Xiaocheng, 2017/03/29 02:16:03]

|EphemeralRange| is just a alias, which cannot be forward declared.

In fact, this bothers me a little because now a lot of headers have to include
the full EphemeralRange.h instead of a forward declaration, which increases
compiling time.

Maybe we should split EphemeralRange.h into two headers:

EphemeralRangeFwd.h:

template <typename Strategy> class EphemeralRangeTemplate;
using EphemeralRange = EphemeralRangeTemplate<EditingStrategy>;
using EphemeralRangeInFlatTree =
EphemeralRangeTemplate<EditingInFlatTreeStrategy>;

EphemeralRange.h:

#include "EphemeralRangeFwd.h"

template <typename Strategy>
class EphemeralRange {
  // Full class declaration
};

Then we can include EphemeralRangeFwd.h in other header files, and
EphemeralRange.h in .cpp files.

Or maybe we can have an "EditingForward.h" collecting all such forward template
class and alias declarations.

 #include "core/editing/PositionWithAffinity.h"
 #include "core/layout/LayoutObjectChildList.h"
 #include "core/layout/MapCoordinatesFlags.h"
 #include "core/layout/ScrollAlignment.h"
 #include "core/layout/SubtreeLayoutScope.h"
 #include "core/layout/api/HitTestAction.h"
 #include "core/layout/api/SelectionState.h"
 #include "core/layout/compositing/CompositingState.h"
 #include "core/loader/resource/ImageResourceObserver.h"
 #include "core/paint/LayerHitTestRects.h"
@@ skipping 1231 matching lines @@
   // integral size and the position has fractional values, the resultant
   // IntRect can be larger than the integral size.
   IntRect absoluteBoundingBoxRect(MapCoordinatesFlags = 0) const;
   // FIXME: This function should go away eventually
   IntRect absoluteBoundingBoxRectIgnoringTransforms() const;
 
   // Build an array of quads in absolute coords for line boxes
   virtual void absoluteQuads(Vector<FloatQuad>&,
                              MapCoordinatesFlags mode = 0) const {}
 
-  static FloatRect absoluteBoundingBoxRectForRange(const Range*);
+  static FloatRect absoluteBoundingBoxRectForRange(const EphemeralRange&);
 
   // The bounding box (see: absoluteBoundingBoxRect) including all descendant
   // bounding boxes.
   IntRect absoluteBoundingBoxRectIncludingDescendants() const;
 
   // For accessibility, we want the bounding box rect of this element
   // in local coordinates, which can then be converted to coordinates relative
   // to any ancestor using, e.g., localToAncestorTransform.
   virtual FloatRect localBoundingBoxRectForAccessibility() const = 0;
 
@@ skipping 1487 matching lines @@
 CORE_EXPORT void showLineTree(const blink::LayoutObject*);
 CORE_EXPORT void showLayoutTree(const blink::LayoutObject* object1);
 // We don't make object2 an optional parameter so that showLayoutTree
 // can be called from gdb easily.
 CORE_EXPORT void showLayoutTree(const blink::LayoutObject* object1,
                                 const blink::LayoutObject* object2);
 
 #endif
 
 #endif  // LayoutObject_h