Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Unified Diff: third_party/WebKit/Source/web/tests/TextFinderTest.cpp

Issue 2775663008: LayoutObject::absoluteBoundingBoxRectForRange() should take EphemeralRange (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/TextFinderTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/TextFinderTest.cpp b/third_party/WebKit/Source/web/tests/TextFinderTest.cpp
index 15087f0523ff45b51328fd164d6231bd518bd0a8..c74495b1e9513d5c9d7f5b3af0bc580a35c5f532 100644
--- a/third_party/WebKit/Source/web/tests/TextFinderTest.cpp
+++ b/third_party/WebKit/Source/web/tests/TextFinderTest.cpp
@@ -65,8 +65,9 @@ WebFloatRect TextFinderTest::findInPageRect(Node* startContainer,
int startOffset,
Node* endContainer,
int endOffset) {
- Range* range = Range::create(startContainer->document(), startContainer,
- startOffset, endContainer, endOffset);
+ const Position startPosition(startContainer, startOffset);
+ const Position endPosition(endContainer, endOffset);
+ EphemeralRange range(startPosition, endPosition);
return WebFloatRect(findInPageRectFromRange(range));
}

Powered by Google App Engine
This is Rietveld 408576698