LayoutObject::absoluteBoundingBoxRectForRange() should take EphemeralRange

third_party/WebKit/Source/web/FindInPageCoordinates.cpp

Index: third_party/WebKit/Source/web/FindInPageCoordinates.cpp
diff --git a/third_party/WebKit/Source/web/FindInPageCoordinates.cpp b/third_party/WebKit/Source/web/FindInPageCoordinates.cpp
index c3e592e3451d8cb0eaff9b2e34fdb5f50c6fab26..d78bac5194e7208f14c2c2a80252a6de70cc3a14 100644
--- a/third_party/WebKit/Source/web/FindInPageCoordinates.cpp
+++ b/third_party/WebKit/Source/web/FindInPageCoordinates.cpp
@@ -143,13 +143,13 @@ FloatRect findInPageRectFromAbsoluteRect(const FloatRect& inputRect,
   return normalizedRect;
 }
 
-FloatRect findInPageRectFromRange(Range* range) {
-  if (!range || !range->firstNode())
+FloatRect findInPageRectFromRange(EphemeralRange& range) {
+  if (range.isNull() || !range.startPosition().nodeAsRangeFirstNode())

[Xiaocheng, 2017/03/24 18:19:26]

Could you store the result of |range.startPosition().nodeAsRangeFirstNode()| to
eliminate repeated computation?

     return FloatRect();
 
   return findInPageRectFromAbsoluteRect(
       LayoutObject::absoluteBoundingBoxRectForRange(range),
-      range->firstNode()->layoutObject());
+      range.startPosition().nodeAsRangeFirstNode()->layoutObject());
 }
 
 }  // namespace blink