Adds NetworkConnect::ConnectToNetworkId(), uses it in detailed VPN page

Adds NetworkConnect::DisconnectFromNetworkId(), uses it in detailed VPN page

BUG=704299
TEST=NetworkConnectTest.ConnectThenDisconnectWiFiNetwork

Review-Url: https://codereview.chromium.org/2775663005
Cr-Commit-Position: refs/heads/master@{#459276}
Committed: https://chromium.googlesource.com/chromium/src/+/c6eefbe8f53fdcc35ec42a4af901eefcd612dcc9

[varkha, 2017-03-23 21:23:59]

The CQ bit was checked by varkha@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 21:24:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[varkha, 2017-03-23 21:24:53]

Description was changed from

==========
Adds NetworkConnect::ConnectToNetworkId(), uses it in detailed VPN page

BUG=704299
==========

to

==========
Adds NetworkConnect::ConnectToNetworkId(), uses it in detailed VPN page

BUG=704299
TEST=NetworkConnectTest.ConnectThenDisconnectWiFiNetwork
==========

[varkha, 2017-03-23 21:26:40]

varkha@chromium.org changed reviewers:
+ stevenjb@chromium.org

[varkha, 2017-03-23 21:26:40]

stevenjb@, can you please take a look? Decided against plumbing through
NetworkListDelegate since indeed this adds little and does not need to use bits
in NetworkStateListDetailedView unlike handling ConnectToNetworkId().
Thanks!

[stevenjb, 2017-03-23 21:43:43]

Thanks! Just one simplification suggestion, otherwise lgtm.

https://codereview.chromium.org/2775663005/diff/20001/ash/common/system/chrom...
File ash/common/system/chromeos/network/vpn_list_view.cc (right):

https://codereview.chromium.org/2775663005/diff/20001/ash/common/system/chrom...
ash/common/system/chromeos/network/vpn_list_view.cc:35: #include
"chromeos/network/network_connection_handler.h"
No longer needed?

https://codereview.chromium.org/2775663005/diff/20001/chromeos/network/networ...
File chromeos/network/network_connect.cc (right):

https://codereview.chromium.org/2775663005/diff/20001/chromeos/network/networ...
chromeos/network/network_connect.cc:82: void CallDisconnectFromNetwork(const
std::string& network_id);
We don't really need this. CallConnectToNetwork exists because it has multiple
entry points.

[commit-bot: I haz the power, 2017-03-23 22:04:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 22:04:36]

Dry run: This issue passed the CQ dry run.

[varkha, 2017-03-23 22:46:55]

Thanks!

https://codereview.chromium.org/2775663005/diff/20001/ash/common/system/chrom...
File ash/common/system/chromeos/network/vpn_list_view.cc (right):

https://codereview.chromium.org/2775663005/diff/20001/ash/common/system/chrom...
ash/common/system/chromeos/network/vpn_list_view.cc:35: #include
"chromeos/network/network_connection_handler.h"
On 2017/03/23 21:43:43, stevenjb wrote:
> No longer needed?

Done.

https://codereview.chromium.org/2775663005/diff/20001/chromeos/network/networ...
File chromeos/network/network_connect.cc (right):

https://codereview.chromium.org/2775663005/diff/20001/chromeos/network/networ...
chromeos/network/network_connect.cc:82: void CallDisconnectFromNetwork(const
std::string& network_id);
On 2017/03/23 21:43:43, stevenjb wrote:
> We don't really need this. CallConnectToNetwork exists because it has multiple
> entry points.

Done.

[varkha, 2017-03-23 22:48:43]

The CQ bit was checked by varkha@chromium.org

[varkha, 2017-03-23 22:48:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/2775663005/#ps40001
(title: "Adds NetworkConnect::ConnectToNetworkId(), uses it in detailed VPN page
(nits)")

[commit-bot: I haz the power, 2017-03-23 22:49:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 23:26:17]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490309323388220,
"parent_rev": "10eb727b576263f0d6515b38752337aa05157aab", "commit_rev":
"c6eefbe8f53fdcc35ec42a4af901eefcd612dcc9"}

[commit-bot: I haz the power, 2017-03-23 23:27:00]

Description was changed from

==========
Adds NetworkConnect::ConnectToNetworkId(), uses it in detailed VPN page

BUG=704299
TEST=NetworkConnectTest.ConnectThenDisconnectWiFiNetwork
==========

to

==========
Adds NetworkConnect::ConnectToNetworkId(), uses it in detailed VPN page

BUG=704299
TEST=NetworkConnectTest.ConnectThenDisconnectWiFiNetwork

Review-Url: https://codereview.chromium.org/2775663005
Cr-Commit-Position: refs/heads/master@{#459276}
Committed:
https://chromium.googlesource.com/chromium/src/+/c6eefbe8f53fdcc35ec42a4af901...
==========

[commit-bot: I haz the power, 2017-03-23 23:27:01]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c6eefbe8f53fdcc35ec42a4af901...

[varkha, 2017-03-27 19:50:53]

Description was changed from

==========
Adds NetworkConnect::ConnectToNetworkId(), uses it in detailed VPN page

BUG=704299
TEST=NetworkConnectTest.ConnectThenDisconnectWiFiNetwork

Review-Url: https://codereview.chromium.org/2775663005
Cr-Commit-Position: refs/heads/master@{#459276}
Committed:
https://chromium.googlesource.com/chromium/src/+/c6eefbe8f53fdcc35ec42a4af901...
==========

to

==========
Adds NetworkConnect::DisconnectFromNetworkId(), uses it in detailed VPN page

BUG=704299
TEST=NetworkConnectTest.ConnectThenDisconnectWiFiNetwork

Review-Url: https://codereview.chromium.org/2775663005
Cr-Commit-Position: refs/heads/master@{#459276}
Committed:
https://chromium.googlesource.com/chromium/src/+/c6eefbe8f53fdcc35ec42a4af901...
==========