Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 277563008: [Signin] Remove a reference to an obsolete bug. (Closed)

Created:
6 years, 7 months ago by Ilya Sherman
Modified:
6 years, 7 months ago
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, maniscalco+watch_chromium.org
Visibility:
Public.

Description

[Signin] Remove a reference to an obsolete bug. BUG=none TEST=none R=rogerta@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269634

Patch Set 1 #

Total comments: 2

Patch Set 2 : Revert unrelated diffs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M chrome/browser/ui/sync/one_click_signin_sync_observer.cc View 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Ilya Sherman
6 years, 7 months ago (2014-05-09 03:46:18 UTC) #1
Roger Tawa OOO till Jul 10th
lgtm https://codereview.chromium.org/277563008/diff/1/chrome/browser/services/gcm/gcm_service.cc File chrome/browser/services/gcm/gcm_service.cc (right): https://codereview.chromium.org/277563008/diff/1/chrome/browser/services/gcm/gcm_service.cc#newcode856 chrome/browser/services/gcm/gcm_service.cc:856: } A lot of crashes were reported yesterday ...
6 years, 7 months ago (2014-05-09 11:51:00 UTC) #2
Ilya Sherman
https://codereview.chromium.org/277563008/diff/1/chrome/browser/services/gcm/gcm_service.cc File chrome/browser/services/gcm/gcm_service.cc (right): https://codereview.chromium.org/277563008/diff/1/chrome/browser/services/gcm/gcm_service.cc#newcode856 chrome/browser/services/gcm/gcm_service.cc:856: } On 2014/05/09 11:51:00, Roger Tawa wrote: > A ...
6 years, 7 months ago (2014-05-09 20:16:56 UTC) #3
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 7 months ago (2014-05-09 20:17:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/277563008/20001
6 years, 7 months ago (2014-05-09 20:18:08 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-10 20:45:34 UTC) #6
Message was sent while issue was closed.
Change committed as 269634

Powered by Google App Engine
This is Rietveld 408576698